Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cell background for edit actions column in Table v2 #15233

Merged
merged 4 commits into from
Jul 20, 2022
Merged

fix: cell background for edit actions column in Table v2 #15233

merged 4 commits into from
Jul 20, 2022

Conversation

sbalaji1192
Copy link
Contributor

@sbalaji1192 sbalaji1192 commented Jul 15, 2022 •
edited
Loading

Fixes #15174

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jul 15, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jul 20, 2022 at 4:43AM (UTC)

@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Bug Something isn't working Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Table Widget labels Jul 15, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

jsartisan
jsartisan previously approved these changes Jul 18, 2022
View reviewed changes
@sbalaji1192
Copy link
Contributor Author

/ok-to-test sha=75410e8

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2688472137.
Workflow: Appsmith External Integration Test Workflow.
Commit: 75410e8.
PR: 15233.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2688472137.
Commit: 75410e8.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 622.72 588.78 669.44 1369.17 663.78 663.78 782.78 42.09 37.64
painting 7.43 4.57 5.71 4.15 5.38 5.38 5.45 23.30 20.92
rendering 97.81 93 115.54 94.79 97.01 97.01 99.63 9.12 8.16
BIND_TABLE_DATA
scripting 2245.85 2280.72 2204.18 2210.59 2466.75 2245.85 2281.62 4.73 4.23
painting 17.42 11.22 26.81 10.17 15.94 15.94 16.31 40.59 36.30
rendering 780.48 698.23 681.04 681.53 729.84 698.23 714.22 5.88 5.26
CLICK_ON_TABLE_ROW
scripting 1280.85 1399.35 1391.71 1349.08 1328.72 1349.08 1349.94 3.59 3.21
painting 11.9 20.94 18.87 11.8 12.51 12.51 15.2 28.68 25.66
rendering 282.72 300.09 293.57 298.75 288.69 293.57 292.76 2.46 2.20
UPDATE_POST_TITLE
scripting 2454.15 2361.34 2493.09 2331.56 2349.26 2361.34 2397.88 2.97 2.66
painting 12.28 12.62 14.52 13.55 11.69 12.62 12.93 8.58 7.73
rendering 395.43 396.3 402.48 399.66 391.59 396.3 397.09 1.05 0.94
OPEN_MODAL
scripting 952.76 1027.27 1007.69 1003.45 1088.71 1007.69 1015.98 4.83 4.32
painting 17.59 11.87 13.08 9.56 11.38 11.87 12.7 23.70 21.26
rendering 352.28 361.15 353.76 357.88 362.38 357.88 357.49 1.24 1.11
CLOSE_MODAL
scripting 853 559.4 622.31 548.49 610.5 610.5 638.74 19.40 17.35
painting 4.75 5.39 5.23 5.77 5.76 5.39 5.38 7.81 7.06
rendering 523.6 506.93 553.27 514.5 536.43 523.6 526.95 3.49 3.12
SELECT_WIDGET_MENU_OPEN
scripting 1192.09 1186.57 1193.66 1155.37 1147.56 1186.57 1175.05 1.86 1.66
painting 6.99 18.91 7.77 6.19 6.24 6.99 9.22 59.22 52.93
rendering 590.39 600.64 637.79 608.92 606.95 606.95 608.94 2.90 2.60
SELECT_WIDGET_SELECT_OPTION
scripting 146.62 208.17 160.15 165.47 153.16 160.15 166.71 14.54 13.00
painting 6.91 4.3 2.14 5.19 2.83 4.3 4.27 44.50 39.81
rendering 11.41 15.25 11.26 12.12 15.05 12.12 13.02 15.13 13.59

@vivekverma2312
Copy link

Tested and working fine.

@github-actions github-actions bot added Release Blocker This issue must be resolved before the release Table Widget V2 Issues related to Table Widget V2 labels Jul 20, 2022
@sbalaji1192
Copy link
Contributor Author

/ok-to-test sha=f467d9e

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2702263044.
Workflow: Appsmith External Integration Test Workflow.
Commit: f467d9e.
PR: 15233.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2702263044.
Commit: f467d9e.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 679.73 579.49 1405.86 622.89 595.27 622.89 776.65 45.55 40.75
painting 4.98 3.95 7.65 8.62 4.17 4.98 5.87 36.29 32.37
rendering 97.54 98.74 93.97 96.14 97.58 97.54 96.79 1.89 1.68
BIND_TABLE_DATA
scripting 2343.45 2295.13 2473.29 2296.15 2331.06 2331.06 2347.82 3.12 2.79
painting 22.78 15.45 19.7 19.86 10.34 19.7 17.63 27.45 24.56
rendering 789.7 737.09 749.17 710.77 794.08 749.17 756.16 4.69 4.20
CLICK_ON_TABLE_ROW
scripting 1546.35 1366.22 1370.55 1380.44 1460.41 1380.44 1424.79 5.48 4.90
painting 9.48 11.06 10.18 10.1 9.46 10.1 10.06 6.46 5.86
rendering 294.53 300.52 286.62 292.4 293.26 293.26 293.47 1.69 1.52
UPDATE_POST_TITLE
scripting 2522.12 2726.27 2601.22 2634.52 2353.49 2601.22 2567.52 5.46 4.89
painting 16.14 14.92 15.34 12.99 14.46 14.92 14.77 7.92 7.11
rendering 405.63 423.61 409.37 409.32 403.5 409.32 410.29 1.92 1.71
OPEN_MODAL
scripting 1053.69 1039.39 975.47 1000.63 983.35 1000.63 1010.51 3.41 3.05
painting 12.93 14.35 10.43 10.16 8.96 10.43 11.37 19.44 17.33
rendering 368.79 370.55 346.59 358.44 354.11 358.44 359.7 2.80 2.50
CLOSE_MODAL
scripting 565.77 655.35 561.29 719.83 545.7 565.77 609.59 12.33 11.02
painting 5.28 6.01 4.31 5.1 4.57 5.1 5.05 13.07 11.68
rendering 526.07 565.59 517.43 523.58 527.6 526.07 532.05 3.60 3.22
SELECT_WIDGET_MENU_OPEN
scripting 1161.95 1114.96 1130.92 1119.93 1140.27 1130.92 1133.61 1.64 1.47
painting 4.96 5.95 6.5 7.15 5.55 5.95 6.02 14.12 12.62
rendering 601.24 609.37 625.17 593.62 593.39 601.24 604.56 2.19 1.96
SELECT_WIDGET_SELECT_OPTION
scripting 159.9 155.8 155.58 159.49 155.27 155.8 157.21 1.45 1.30
painting 5.67 8.78 1.93 2.32 4.86 4.86 4.71 59.02 52.87
rendering 11.94 12.11 11.13 12.19 10.88 11.94 11.65 5.15 4.64

@sbalaji1192 sbalaji1192 merged commit 71e581d into release Jul 20, 2022
@sbalaji1192 sbalaji1192 deleted the fix/table-v2-editactions-bg branch July 20, 2022 06:13
ashit-rath pushed a commit that referenced this pull request Jul 20, 2022
@sbalaji1192 @ashit-rath
fix: cell background for edit actions column in Table v2 (#15233)
64c693b 
(cherry picked from commit 71e581d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Release Blocker This issue must be resolved before the release Table Widget V2 Issues related to Table Widget V2 Table Widget Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Background color is not applied to save/Discard column on table widget v2
3 participants
@sbalaji1192 @vivekverma2312 @jsartisan