Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TreeWidgets issues #16401

Merged
merged 4 commits into from
Sep 1, 2022
Merged

fix: TreeWidgets issues #16401

merged 4 commits into from
Sep 1, 2022

Conversation

Tooluloope
Copy link
Contributor

Description

This Fixes issues with Both Single Tree Select and Multi Tree Select.

  • Clearing Values
  • SelectedOptionLabels for both widgets

Fixes #16367
Fixes #16365
Fixes #15466

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Aug 30, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 3:16PM (UTC)

@Tooluloope Tooluloope self-assigned this Aug 30, 2022
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith High This issue blocks a user from building or impacts a lot of users MultiTree Select Widget Issues related to MultiTree Select Widget Needs Triaging Needs attention from maintainers to triage OnPageLoad OnPageLoad issues on functions and queries Regressed Scenarios that were working before but have now regressed Release TreeSelect Issues related to TreeSelect Widget labels Aug 30, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@Tooluloope Tooluloope removed Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Release Regressed Scenarios that were working before but have now regressed Needs Triaging Needs attention from maintainers to triage Javascript Product Issues related to users writing javascript in appsmith OnPageLoad OnPageLoad issues on functions and queries labels Aug 30, 2022
@github-actions github-actions bot added Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage OnPageLoad OnPageLoad issues on functions and queries Regressed Scenarios that were working before but have now regressed Release labels Aug 30, 2022
@Tooluloope Tooluloope removed the request for review from sbalaji1192 August 30, 2022 10:30
ashit-rath
ashit-rath reviewed Aug 30, 2022
View reviewed changes
app/client/src/widgets/MultiSelectTreeWidget/widget/index.tsx Outdated Show resolved Hide resolved
app/client/src/widgets/WidgetUtils.ts
* This would be flattened to Array -> { value, label } , { value, label }
*/

export const flat = (array: DropdownOption[]) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a lodash function to flatten which you can use in the derived properties.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it would work for this use case. What youre refering to is that Flatten or flattenDeep

app/client/src/widgets/SingleSelectTreeWidget/widget/derived.js Outdated Show resolved Hide resolved
ashit-rath
ashit-rath previously approved these changes Aug 31, 2022
View reviewed changes
@Tooluloope
Copy link
Contributor Author

/ok-to-test sha=cbee2c3

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2961781288.
Workflow: Appsmith External Integration Test Workflow.
Commit: cbee2c3.
PR: 16401.

@shadabbuchh
Copy link

All the reported issues pertaining to TreeSelect & MultiTreeSelect widgets are fixed and working fine.
https://www.loom.com/share/72b543e08d984647a758e168da972c0e
Screenshot 2022-08-31 at 12.49.43 PM.png

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2961781288.
Commit: cbee2c3.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 301.2 314.42 302.57 309.19 336.47 309.19 312.77 11.28 4.57 4.08
painting 3.27 3.11 3.5 3.18 3.44 3.27 3.3 11.82 5.15 4.55
rendering 105.94 109.22 106.99 108.31 114.67 108.31 109.03 8.01 3.11 2.79
BIND_TABLE_DATA
scripting 1231.58 1214.43 1331.18 1277.1 1207.11 1231.58 1252.28 9.91 4.14 3.70
painting 15.74 15.45 14.2 16.48 21.71 15.74 16.72 44.92 17.40 15.55
rendering 435.17 452.16 489.77 471.35 496.18 471.35 468.93 13.01 5.44 4.87
CLICK_ON_TABLE_ROW
scripting 812.37 877.88 856.65 882.92 963.63 877.88 878.69 17.21 6.26 5.60
painting 10.22 20.16 17.35 11.16 13.44 13.44 14.47 68.69 29.09 25.98
rendering 333.28 306.01 309.33 311.55 328.35 311.55 317.7 8.58 3.86 3.45
UPDATE_POST_TITLE
scripting 1440.88 1486.16 1344.27 1264.75 1515.6 1440.88 1410.33 17.79 7.38 6.60
painting 16.55 19.04 15.41 12.64 18.32 16.55 16.39 39.05 15.50 13.85
rendering 461.02 484.81 461.38 438.09 515.95 461.38 472.25 16.49 6.24 5.59
OPEN_MODAL
scripting 540.81 566.88 530.38 527.94 611.42 540.81 555.49 15.03 6.28 5.61
painting 14.29 8.86 10.14 18.07 17.69 14.29 13.81 66.69 30.63 27.37
rendering 386.05 390.48 386.24 376.75 444.16 386.24 396.74 16.99 6.80 6.08
CLOSE_MODAL
scripting 289.64 358.39 335.95 780.07 408.2 358.39 434.45 112.89 45.54 40.73
painting 4.63 6.04 7.62 8.41 11.21 7.62 7.58 86.81 32.98 29.42
rendering 601.01 656.69 633.8 619.09 744.5 633.8 651.02 22.04 8.62 7.71
SELECT_WIDGET_MENU_OPEN
scripting 1128.25 1149.83 1139.09 1156.66 1180.54 1149.83 1150.87 4.54 1.72 1.54
painting 6.91 9.1 5.92 9.4 10.94 9.1 8.45 59.41 23.91 21.42
rendering 646.89 636.88 694.95 651.07 685.38 651.07 663.03 8.76 3.85 3.44
SELECT_WIDGET_SELECT_OPTION
scripting 152.6 157.09 144.22 166.27 159.09 157.09 155.85 14.15 5.24 4.68
painting 3.85 3.83 7.16 8.06 2.16 3.85 5.01 117.76 49.70 44.51
rendering 314.67 312.43 330.75 328.75 317.25 317.25 320.77 5.71 2.62 2.34

@Tooluloope
Copy link
Contributor Author

/ok-to-test sha=ddda2bc

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2964974942.
Workflow: Appsmith External Integration Test Workflow.
Commit: ddda2bc.
PR: 16401.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2964974942.
Commit: ddda2bc.
Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 321.78 317.25 313.81 290.66 294.95 313.81 307.69 10.11 4.54 4.06
painting 4.96 3.45 3.54 3.32 3.32 3.45 3.72 44.09 18.82 16.94
rendering 109.3 107.74 112.77 110.93 108.54 109.3 109.86 4.58 1.83 1.64
BIND_TABLE_DATA
scripting 1502.65 1502.87 1514.48 1541.03 1604.45 1514.48 1533.1 6.64 2.79 2.50
painting 12.99 17.12 20.04 14.7 16.01 16.01 16.17 43.60 16.39 14.66
rendering 426.27 435.08 436.03 448.72 459.84 436.03 441.19 7.61 2.98 2.67
CLICK_ON_TABLE_ROW
scripting 779.51 838.69 888.39 864.4 945.44 864.4 863.29 19.22 7.09 6.35
painting 8.92 11.82 11.44 10.37 9.94 10.37 10.5 27.62 11.14 9.90
rendering 302.58 296.42 318.42 300.05 323.2 302.58 308.13 8.69 3.86 3.45
UPDATE_POST_TITLE
scripting 1355.38 1819.89 1377.55 1302.96 1374.83 1374.83 1446.12 35.75 14.60 13.05
painting 14.21 16.18 21.85 12.94 16.31 16.18 16.3 54.66 20.92 18.71
rendering 448.66 451.65 472.16 450.92 459.58 451.65 456.59 5.15 2.11 1.89
OPEN_MODAL
scripting 505.33 485.45 518.17 505.82 1039.77 505.82 610.91 90.74 39.29 35.14
painting 14.12 15.6 11.39 17.26 14.27 14.27 14.53 40.40 14.87 13.28
rendering 386.42 373.99 387.24 386.23 395.76 386.42 385.93 5.64 2.01 1.80
CLOSE_MODAL
scripting 312.78 342.57 270.66 324.34 379.33 324.34 325.94 33.34 12.23 10.94
painting 5.47 5.26 5.29 17.52 13.26 5.47 9.36 130.98 61.00 54.49
rendering 627.25 625.15 639.99 646.19 707.68 639.99 649.25 12.71 5.21 4.66
SELECT_WIDGET_MENU_OPEN
scripting 1056.85 1155.18 1105.36 1068.38 1220.83 1105.36 1121.32 14.62 6.03 5.39
painting 5.31 6.66 7.1 4.74 10.01 6.66 6.76 77.96 30.33 27.22
rendering 594.81 634.77 638.98 604.18 720.99 634.77 638.75 19.75 7.79 6.97
SELECT_WIDGET_SELECT_OPTION
scripting 138.16 144.75 145.3 135.29 226.8 144.75 158.06 57.90 24.46 21.88
painting 4.81 3.87 3.56 1.88 3.67 3.67 3.56 82.30 29.78 26.69
rendering 311.15 344 317.02 316.1 508.6 317.02 359.37 54.94 23.49 21.01

@Tooluloope Tooluloope merged commit 6bed5a3 into release Sep 1, 2022
@Tooluloope Tooluloope deleted the fix/Tree-select-issues branch September 1, 2022 05:40
This was referenced Sep 3, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashit-rath ashit-rath ashit-rath approved these changes

Assignees

@Tooluloope Tooluloope

Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Javascript Product Issues related to users writing javascript in appsmith MultiTree Select Widget Issues related to MultiTree Select Widget Needs Triaging Needs attention from maintainers to triage OnPageLoad OnPageLoad issues on functions and queries Regressed Scenarios that were working before but have now regressed Release TreeSelect Issues related to TreeSelect Widget Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
3 participants
@Tooluloope @shadabbuchh @ashit-rath