Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fixing the package step for test-build-docker workflow #16661

Merged
merged 1 commit into from
Sep 9, 2022
Merged

ci: Fixing the package step for test-build-docker workflow #16661

merged 1 commit into from
Sep 9, 2022

Conversation

mohanarpit
Copy link
Member

Description

The depot docker step wasn't initialized. This was causing Docker builds to fail.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Relying on CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@mohanarpit
ci: Fixing the package step for test-build-docker workflow
2e8dfcd 
The depot docker step wasn't initialized. This was causing Docker builds to fail.
@vercel
Copy link

vercel bot commented Sep 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
appsmith ⬜️ Ignored (Inspect) Sep 9, 2022 at 6:17AM (UTC)

@github-actions github-actions bot added CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Sep 9, 2022
@mohanarpit mohanarpit merged commit c0e1a62 into release Sep 9, 2022
@mohanarpit mohanarpit deleted the chore/fix-package-test-build branch September 9, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatinappsmith yatinappsmith yatinappsmith approved these changes

Assignees
No one assigned
Labels
CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohanarpit @yatinappsmith