Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: google sheet ui issues, removed redundant code #18785

Merged
merged 20 commits into from
Dec 20, 2022
Merged

fix: google sheet ui issues, removed redundant code #18785

merged 20 commits into from
Dec 20, 2022

Conversation

AmanAgarwal041
Copy link
Contributor

Description

This Pr deals with :

  • Google Sheets UI fixes
  • Limiting users to build new query if the Google Sheet Datasource is unauthorized
  • Removal of some redundant code and moving it to one place to update the ui designs in future easily

Fixes #18032

Media
Loom Video for Google Sheet Fixes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link

vercel bot commented Dec 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 3:20PM (UTC)

@vercel
Copy link

vercel bot commented Dec 8, 2022

Deployment failed with the following error:

Resource is limited - try again in 52 minutes (more than 100, code: "api-deployments-free-per-day").

@github-actions github-actions bot added Query & JS Pod Issues related to the query & JS Pod Google Sheets Issues related to Google Sheets Integrations Product Issues related to a specific integration labels Dec 8, 2022
@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=a01565e

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3649631421.
Workflow: Appsmith External Integration Test Workflow.
Commit: a01565e.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3649631421_1

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=7329c76

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3655332956.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7329c76.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3655332956_1

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=cb0147b

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3659094115.
Workflow: Appsmith External Integration Test Workflow.
Commit: cb0147b.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3659094115_1

berzerkeer
berzerkeer previously approved these changes Dec 10, 2022
View reviewed changes
@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=6b3a573

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3667767912.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6b3a573.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3667767912_1

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=a59c265

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=d0eb0fb

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3692168981.
Workflow: Appsmith External Integration Test Workflow.
Commit: d0eb0fb.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3692168981_1

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=f675f13

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3701982169.
Workflow: Appsmith External Integration Test Workflow.
Commit: f675f13.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3701982169_1

sneha122
sneha122 previously approved these changes Dec 15, 2022
View reviewed changes
@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test sha=eda1b3e

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3705895407.
Workflow: Appsmith External Integration Test Workflow.
Commit: eda1b3e.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3705895407_1

@sneha122
Copy link
Contributor

/ok-to-test sha=d7b7ec8

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3711108592.
Workflow: Appsmith External Integration Test Workflow.
Commit: d7b7ec8.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3711108592_1

@sneha122
Copy link
Contributor

/ok-to-test sha=23c9b8a

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3720633041.
Workflow: Appsmith External Integration Test Workflow.
Commit: 23c9b8a.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3720633041_1

@prapullac prapullac added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Dec 20, 2022
@sneha122
Copy link
Contributor

/perf-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3738149552.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 18785.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3738149552_1

@trishaanand trishaanand merged commit 4a38160 into release Dec 20, 2022
@trishaanand trishaanand deleted the fix/gsheet-ui-fixes branch December 20, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitakinger ankitakinger ankitakinger left review comments

@sneha122 sneha122 sneha122 left review comments

@Irongade Irongade Irongade approved these changes

@berzerkeer berzerkeer berzerkeer left review comments

Assignees
No one assigned
Labels
Google Sheets Issues related to Google Sheets Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

While creating a gsheet datasource, creation of the query should only be possible on valid datasource
7 participants
@AmanAgarwal041 @sneha122 @ankitakinger @Irongade @berzerkeer @trishaanand @prapullac