feat: font update - PT root UI medium #33008

albinAppsmith · 2024-04-29T06:03:02Z

Description

This PR update default font to PT Root UI.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9001227602
Commit: 491aaf0
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Style
- Removed font smoothing properties from the body styling to enhance text clarity and appearance across web browsers.

albinAppsmith · 2024-04-29T06:04:05Z

/build-deploy-preview skip-test=true

github-actions · 2024-04-29T06:04:26Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8874024992.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .

github-actions · 2024-04-29T06:19:40Z

Deploy-Preview-URL: https://ce-33008.dp.appsmith.com

…o pt-root-ui-medium

coderabbitai · 2024-04-29T09:18:46Z

Walkthrough

The changes encompass standardizing font families across multiple files by utilizing the custom CSS variable --ads-v2-font-family, facilitating global font management and consistency. This initiative supports the broader objective of transitioning to the PT Root UI font system for a cohesive user experience.

Changes

File Path	Change Summary
`app/client/public/404.css`, `app/client/public/content.css`	Updated `font-family` to use `var(--ads-v2-font-family)` instead of specific font families.
`app/client/src/components/editorComponents/Debugger/ErrorLogs/components/LogCollapseData.tsx`, `app/client/src/components/editorComponents/Debugger/ErrorLogs/components/LogItem.tsx`	Replaced predefined font stacks with `var(--ads-v2-font-family)` in `reactJsonProps` objects.
`app/client/src/constants/Fonts.tsx`	Updated `TextFonts` constant to use `var(--ads-v2-font-family)` for font family definition.
`app/client/src/index.css`	Removed `-webkit-font-smoothing: antialiased;` and `-moz-osx-font-smoothing: grayscale;` from `body` styling.

Possibly related issues

[Task] - Update system font to PT root UI #32720: The updates to the font families using a custom variable are in line with the goal of switching to the PT Root UI font, ensuring a consistent font experience throughout the application.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0da712b and 491aaf0.

Files ignored due to path filters (2)

app/client/package.json is excluded by !**/*.json
app/client/yarn.lock is excluded by !**/*.lock, !**/*.lock

Files selected for processing (1)

app/client/src/index.css (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/src/index.css

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

albinAppsmith · 2024-04-29T10:21:07Z

/build-deploy-preview skip-test=true

github-actions · 2024-04-29T10:21:32Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8876986562.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .

github-actions · 2024-04-29T10:35:48Z

Deploy-Preview-URL: https://ce-33008.dp.appsmith.com

…o pt-root-ui-medium

albinAppsmith · 2024-04-30T05:58:06Z

/build-deploy-preview skip-test=true

github-actions · 2024-04-30T05:58:27Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8889986084.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .

github-actions · 2024-04-30T06:12:17Z

Deploy-Preview-URL: https://ce-33008.dp.appsmith.com

albinAppsmith · 2024-04-30T07:37:14Z

/build-deploy-preview skip-test=true

github-actions · 2024-04-30T07:37:35Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8891062165.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .

github-actions · 2024-04-30T07:52:51Z

Deploy-Preview-URL: https://ce-33008.dp.appsmith.com

…o pt-root-ui-medium

albinAppsmith · 2024-05-02T09:47:24Z

/build-deploy-preview skip-test=true

github-actions · 2024-05-02T09:47:47Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8921877654.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .

github-actions · 2024-05-02T10:02:32Z

Deploy-Preview-URL: https://ce-33008.dp.appsmith.com

…o pt-root-ui-medium

albinAppsmith · 2024-05-08T11:43:36Z

/build-deploy-preview skip-test=true

github-actions · 2024-05-08T11:44:01Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9001222877.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .

github-actions · 2024-05-08T11:58:23Z

Deploy-Preview-URL: https://ce-33008.dp.appsmith.com

feat: font update

8ca9b1f

albinAppsmith requested a review from KelvinOm as a code owner April 29, 2024 06:03

github-actions bot added IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE Task A simple Todo Enhancement New feature or request labels Apr 29, 2024

albinAppsmith added 6 commits April 29, 2024 12:57

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

b81aeb3

…o pt-root-ui-medium

removed font smoothing

8774084

revert: removed font smoothing

06bfbdc

removed font smoothing

0022377

removed font smoothing

4f28240

removed font smoothing

b911273

albinAppsmith added 2 commits April 29, 2024 15:58

test

8dfc888

revert test

aecd060

albinAppsmith added 2 commits April 30, 2024 11:17

feat: font medium to regular

fa2086c

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

3534d4b

…o pt-root-ui-medium

albinAppsmith added 2 commits April 30, 2024 12:22

fix: font face unification for weights

cacd227

fix: font family to ads variable change

95a862f

KelvinOm previously approved these changes May 1, 2024

View reviewed changes

albinAppsmith added 2 commits May 2, 2024 15:10

added semibold font

64a1b56

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

0da712b

…o pt-root-ui-medium

albinAppsmith dismissed KelvinOm’s stale review via 0da712b May 2, 2024 09:41

fix updated text wrap balance

38c13cf

albinAppsmith added 2 commits May 8, 2024 17:11

fix: package updated to stable

1344f13

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

491aaf0

…o pt-root-ui-medium

albinAppsmith added the ok-to-test Required label for CI label May 8, 2024

albinAppsmith requested a review from hetunandu May 8, 2024 12:07

hetunandu approved these changes May 8, 2024

View reviewed changes

albinAppsmith merged commit fd59d40 into release May 8, 2024
41 checks passed

albinAppsmith deleted the pt-root-ui-medium branch May 8, 2024 12:17

ichik mentioned this pull request May 15, 2024

chore: adjust WDS font weights #33481

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: font update - PT root UI medium #33008

feat: font update - PT root UI medium #33008

albinAppsmith commented Apr 29, 2024 •

edited by github-actions bot

Loading

albinAppsmith commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

coderabbitai bot commented Apr 29, 2024 •

edited

Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

albinAppsmith commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

albinAppsmith commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

albinAppsmith commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

albinAppsmith commented May 2, 2024

github-actions bot commented May 2, 2024

github-actions bot commented May 2, 2024

albinAppsmith commented May 8, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 8, 2024

feat: font update - PT root UI medium #33008

feat: font update - PT root UI medium #33008

Conversation

albinAppsmith commented Apr 29, 2024 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

albinAppsmith commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

coderabbitai bot commented Apr 29, 2024 • edited Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

albinAppsmith commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

albinAppsmith commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

albinAppsmith commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

albinAppsmith commented May 2, 2024

github-actions bot commented May 2, 2024

github-actions bot commented May 2, 2024

albinAppsmith commented May 8, 2024

github-actions bot commented May 8, 2024

github-actions bot commented May 8, 2024

albinAppsmith commented Apr 29, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Apr 29, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)