fix: Widget selection issues - part 1

[riodeuno]

Description

This fixes part of the widget selection issues from #33138

Specifically, the following:

• Modal border radius goes away in preview mode.
• When a widget is selected and we hover over it, the border thickness reduces.
• When clicking on the error button, the property control with the error is not focused.

Automation

/ok-to-test tags="@tag.Anvil"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8939093222
Commit: a94a7ad
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

Walkthrough

The updates primarily involve modifications to widget styling and behavior in a React-based application. Changes include the removal of a style property in widget border functions, an updated condition for setting widget border styles, and the integration of Redux's useDispatch to handle actions within a component, enhancing modularity and maintainability.

Changes

File Path	Change Summary
.../common/hooks/detachedWidgetHooks.ts	Removed borderRadius style setting in useAddBordersToDetachedWidgets.
.../common/hooks/useWidgetBorderStyles.ts	Updated condition to include !isSelected for setting borderColor and borderWidth.
.../editor/AnvilWidgetName/AnvilWidgetNameComponent.tsx	Added Redux useDispatch for action dispatching; replaced direct function call with dispatch.

Possibly related issues

• [Task]: Anvil Widget Selection Issues #33138: The removal of borderRadius could be related to the modal border radius issue in preview mode.
  • Reasoning: The change in borderRadius handling might affect how modal widgets display their borders in different modes.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bea3cc1 and a94a7ad.

Files selected for processing (3)

• app/client/src/layoutSystems/anvil/common/hooks/detachedWidgetHooks.ts (1 hunks)
• app/client/src/layoutSystems/anvil/common/hooks/useWidgetBorderStyles.ts (1 hunks)
• app/client/src/layoutSystems/anvil/editor/AnvilWidgetName/AnvilWidgetNameComponent.tsx (3 hunks)

Additional comments not posted (5)

app/client/src/layoutSystems/anvil/editor/AnvilWidgetName/AnvilWidgetNameComponent.tsx (3)

12-12: Import of useDispatch from react-redux is correctly added to support dispatching actions.

---

40-40: Usage of useDispatch hook to obtain dispatch function is correctly implemented.

---

54-54: Modification of handleDebugClick to use dispatch for action dispatching enhances maintainability and aligns with Redux best practices.

app/client/src/layoutSystems/anvil/common/hooks/useWidgetBorderStyles.ts (1)

55-55: Refinement of border style conditions to include !isSelected ensures consistent border thickness when a widget is selected and then hovered over.

app/client/src/layoutSystems/anvil/common/hooks/detachedWidgetHooks.ts (1)

Line range hint 1-1: Removal of borderRadius setting in useAddBordersToDetachedWidgets correctly addresses the issue of disappearing modal border radius in preview mode.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.