Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Anvil Widget Selection Issues #33138

Open
5 of 10 tasks
riodeuno opened this issue May 2, 2024 · 1 comment
Open
5 of 10 tasks

[Task]: Anvil Widget Selection Issues #33138

riodeuno opened this issue May 2, 2024 · 1 comment
Assignees
@riodeuno
Labels
Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil Task A simple Todo

Comments

@riodeuno
Copy link
Contributor

riodeuno commented May 2, 2024 •
edited

SubTasks

Dealbreakers:

Others:

  • Widget name component takes a few milliseconds to appear in the right position when scrolling.
    additional observation
  • modal label is a tad off its margin
    image
  • Add dark mode styles to widget name component.
  • z-index should be higher for hovered elements (original thread)
    image

Done:

  • Modal border radius goes away in preview mode.
  • When a widget is selected and we hover over it, the border thickness reduces.
  • When clicking on the error button, the property control with the error is not focused.
@riodeuno riodeuno added Task A simple Todo Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil labels May 2, 2024
@riodeuno riodeuno self-assigned this May 2, 2024
@ramsaptami
Copy link
Contributor

@riodeuno the last issue here is okay experience imo, not necessary to solve since it does not hinder interaction

@riodeuno riodeuno mentioned this issue May 3, 2024
Merged
5 tasks
riodeuno added a commit that referenced this issue May 3, 2024
@riodeuno
fix: Widget selection issues - part 1 (#33167)
dd64557 
## Description
This fixes part of the widget selection issues from #33138 

Specifically, the following:
-  [x]  Modal border radius goes away in preview mode.
- [x] When a widget is selected and we hover over it, the border
thickness reduces.
- [x] When clicking on the error button, the property control with the
error is not focused.


## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8939093222>
> Commit: a94a7ad
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8939093222&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riodeuno riodeuno

Labels
Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@riodeuno @ramsaptami