Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: learnability flags turned on by default #33225

Merged
merged 2 commits into from
May 8, 2024

Conversation

sneha122
Copy link
Contributor

@sneha122 sneha122 commented May 7, 2024

Description

For the airgapped testing, we need to remove all the feature flags which are already rolled out to 100% of the users. As part of this task, we have 3 flags in activation/learnability initiatives:

  1. rollout_js_enabled_one_click_binding_enabled
  2. ab_learnability_ease_of_initial_use_enabled
  3. ab_learnability_discoverability_collapse_all_except_data_enabled
  4. rollout_remove_feature_walkthrough_enabled

As immediate measure, we are turning default values of these flags to be true, later on we can plan to completely remove the flags from the code.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

馃攳 Cypress test results

Tip

馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8996740514
Commit: 0816933
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Copy link
Contributor

coderabbitai bot commented May 7, 2024

Walkthrough

Walkthrough

The recent updates involve enabling several feature flags in the FeatureFlag.ts file, enhancing functionalities related to one-click binding, ease of initial use, and specific discoverability behaviors. These changes aim to improve user experience by making the application more intuitive and user-friendly, particularly for new users.

Changes

File Path Change Summary
.../src/ce/entities/FeatureFlag.ts Enabled feature flags for one-click binding, ease of initial use, and selective discoverability collapse.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2770282 and 0816933.
Files selected for processing (1)
  • app/client/src/ce/entities/FeatureFlag.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/client/src/ce/entities/FeatureFlag.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Activation - datasources issues related to activation projects Activation - learnability Activation - learnability Integrations Pod Issues related to a specific integration Task A simple Todo skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels May 7, 2024
@sneha122 sneha122 added ok-to-test Required label for CI and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels May 7, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 7, 2024
Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include rollout_remove_feature_walkthrough_enabled flag as well ? @sneha122

@sneha122
Copy link
Contributor Author

sneha122 commented May 7, 2024

Can we include rollout_remove_feature_walkthrough_enabled flag as well ? @sneha122

@AmanAgarwal041 Done!

@sneha122 sneha122 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 8, 2024
@sneha122 sneha122 merged commit 46ac5de into release May 8, 2024
44 checks passed
@sneha122 sneha122 deleted the fix/learnability-flags-default-on branch May 8, 2024 06:12
trishaanand added a commit that referenced this pull request May 8, 2024
trishaanand added a commit that referenced this pull request May 8, 2024
Reverts #33225

/ok-to-test tags="@tag.Binding,@tag.AutoHeight"<!-- This is an
auto-generated comment: Cypress test results -->
> [!TIP]
> 馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8999564168>
> Commit: 7870a63
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8999564168&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Activation - datasources issues related to activation projects Activation - learnability Activation - learnability Integrations Pod Issues related to a specific integration ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Activation flags which are rolled out to 100% turn them to true by default
3 participants