-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: learnability flags turned on by default #33225
Conversation
WalkthroughWalkthroughThe recent updates involve enabling several feature flags in the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include rollout_remove_feature_walkthrough_enabled
flag as well ? @sneha122
@AmanAgarwal041 Done! |
This reverts commit 46ac5de.
Reverts #33225 /ok-to-test tags="@tag.Binding,@tag.AutoHeight"<!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8999564168> > Commit: 7870a63 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8999564168&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results -->
Description
For the airgapped testing, we need to remove all the feature flags which are already rolled out to 100% of the users. As part of this task, we have 3 flags in activation/learnability initiatives:
As immediate measure, we are turning default values of these flags to be true, later on we can plan to completely remove the flags from the code.
Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Datasource"
馃攳 Cypress test results
Tip
馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8996740514
Commit: 0816933
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?