Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "chore: learnability flags turned on by default" #33277

Merged

Conversation

trishaanand
Copy link
Contributor

@trishaanand trishaanand commented May 8, 2024

Reverts #33225

/ok-to-test tags="@tag.Binding,@tag.AutoHeight"

Tip

馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8999564168
Commit: 7870a63
Cypress dashboard url: Click here!

Copy link
Contributor

coderabbitai bot commented May 8, 2024

Walkthrough

Walkthrough

The recent changes involve modifying the default settings of several feature flags in the FeatureFlag.ts file. Specifically, the updates switch the status of four feature flags from true to false. This alteration potentially scales back the availability or activation of certain features related to feature walkthroughs, one-click binding in JS, and aspects of learnability and discoverability within the application.

Changes

File Path Change Summary
.../src/ce/entities/FeatureFlag.ts Changed default values of four feature flags from true to false, impacting features related to walkthroughs, JS binding, and user learnability.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 370016a and 7870a63.
Files selected for processing (1)
  • app/client/src/ce/entities/FeatureFlag.ts (1 hunks)
Additional comments not posted (4)
app/client/src/ce/entities/FeatureFlag.ts (4)

88-88: Reverted rollout_remove_feature_walkthrough_enabled to false as intended.


89-89: Reverted rollout_js_enabled_one_click_binding_enabled to false as intended.


91-91: Reverted ab_learnability_ease_of_initial_use_enabled to false as intended.


92-92: Reverted ab_learnability_discoverability_collapse_all_except_data_enabled to false as intended.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@trishaanand trishaanand added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 8, 2024
@sneha122 sneha122 self-requested a review May 8, 2024 10:05
@trishaanand trishaanand changed the title Revert "chore: learnability flags turned on by default" chore: Revert "chore: learnability flags turned on by default" May 8, 2024
@trishaanand trishaanand merged commit d873c8f into release May 8, 2024
57 of 60 checks passed
@trishaanand trishaanand deleted the revert-33225-fix/learnability-flags-default-on branch May 8, 2024 10:05
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants