-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Collapsible Bottom View #33441
Conversation
/build-deploy-preview |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9083396662. |
Deploy-Preview-URL: https://ce-33441.dp.appsmith.com |
# Conflicts: # app/client/src/pages/Editor/QueryEditor/QueryDebuggerTabs.tsx
WalkthroughWalkthroughThe recent changes focus on improving the usability of the split-pane debugger in the app's IDE. Updates include selector modifications, component behavior adjustments, and height calculation refinements. Key enhancements involve making the debugger pane collapsible, introducing new components, refining interfaces, and restructuring code for better organization and clarity. Changes
Assessment against linked issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
/build-deploy-preview |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9111581179. |
Deploy-Preview-URL: https://ce-33441.dp.appsmith.com |
/build-deploy-preview |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9116821422. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
app/client/src/components/editorComponents/Debugger/Resizer/index.tsx (1)
27-27
: Add a comment to document the newminHeight
property.To improve code readability and maintainability, consider adding a comment to document the purpose of the new
minHeight
property in theResizerProps
interface.
import { ViewHideBehaviour, ViewDisplayMode } from "IDE/Interfaces/View"; | ||
import { Button } from "design-system"; | ||
|
||
const VIEW_MIN_HEIGHT = 38; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a named constant for the minimum height value.
To improve code readability and maintainability, consider using a named constant for the minimum height value, as suggested in previous comments.
- const VIEW_MIN_HEIGHT = 38;
+ const VIEW_MIN_HEIGHT = 38; // Minimum height for the view
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
const VIEW_MIN_HEIGHT = 38; | |
const VIEW_MIN_HEIGHT = 38; // Minimum height for the view |
Deploy-Preview-URL: https://ce-33441.dp.appsmith.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
This reverts commit dbb07b8.
Description
BottomView
that can be either collapsed or closed.EntityTabs
when it is collapsedFixes #33333
Fixes #33336
Fixes #31402
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Caution
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9175565108
Commit: 8f3b96e
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
Communication
Should the DevRel and Marketing teams inform users about this change?