fix: added serialization for LicenseCE

[NilanshBansal]

Description

After merging the PR #33309, we started to store the Tenant Information in the Redis cache. Redis needs to serialize the objects upon storing and deserialize post fetching.
To do that we need to implement serialization for all the nested user defined Domains.
This was missed for the LicenseCE and Payment object.
Corresponding EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4195

Fixes #33486

Automation

/ok-to-test tags="@tag.Settings, @tag.LicenseAndBilling"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9096922670
Commit: 559bcd6
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/ProductRamps/PrivateEmbedRamp_spec.ts

To know the list of identified flaky tests - Refer here

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

Walkthrough

The LicenseCE class in the appsmith-server module has been updated to implement the Serializable interface. This change ensures that instances of LicenseCE can be serialized, which is crucial for certain operations like caching or transmitting objects.

Changes

File Path	Change Summary
app/server/appsmith-server/src/main/java/...	LicenseCE class now implements the Serializable interface.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Fix Cypress Tests failing for License and Billing Spec (#33486)	❓	Implementing Serializable in LicenseCE may fix some issues, but it is unclear if it directly addresses the Cypress test failures.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f13309e and 559bcd6.

Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/domains/ce/LicenseCE.java (1 hunks)

Additional comments not posted (2)

app/server/appsmith-server/src/main/java/com/appsmith/server/domains/ce/LicenseCE.java (2)

6-7: Good addition of the Serializable interface to ensure the LicenseCE class can be serialized for Redis storage.

---

9-11: Ensure all fields within the LicenseCE class are serializable. The LicensePlan type should also implement Serializable if it contains any non-primitive fields.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[NilanshBansal]

The failing test cypress/e2e/Regression/ClientSide/ProductRamps/PrivateEmbedRamp_spec.ts is unrelated and is not caused due to the PR changes. This can be verified from this dummy PR