Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Cypress Tests failing for License and Billing Spec #33486

Closed
1 task done
NilanshBansal opened this issue May 15, 2024 · 0 comments · Fixed by #33487
Closed
1 task done

[Bug]: Cypress Tests failing for License and Billing Spec #33486

NilanshBansal opened this issue May 15, 2024 · 0 comments · Fixed by #33487
Assignees
@NilanshBansal
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Query & JS Pod Issues related to the query & JS Pod

Comments

@NilanshBansal
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

image

Ref: https://github.com/appsmithorg/appsmith-ee/actions/runs/9092923254

Corresponding EE issue: https://github.com/appsmithorg/appsmith-ee/issues/4189

Steps To Reproduce

Ref: https://github.com/appsmithorg/appsmith-ee/actions/runs/9092923254

Public Sample App

No response

Environment

Production

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

Appsmith 240e8e1 Release
@NilanshBansal NilanshBansal added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels May 15, 2024
@NilanshBansal NilanshBansal self-assigned this May 15, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added High This issue blocks a user from building or impacts a lot of users Production labels May 15, 2024
@NilanshBansal NilanshBansal mentioned this issue May 15, 2024
Merged
2 tasks
@NilanshBansal NilanshBansal added the Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. label May 15, 2024
@github-actions github-actions bot added the Integrations Product Issues related to a specific integration label May 15, 2024
hetunandu pushed a commit that referenced this issue May 15, 2024
@NilanshBansal
fix: added serialization for LicenseCE (#33487)
047385b 
## Description
After merging the PR #33309,
we started to store the Tenant Information in the Redis cache. Redis
needs to serialize the objects upon storing and deserialize post
fetching.
To do that we need to implement serialization for all the nested user
defined Domains.
This was missed for the LicenseCE and Payment object.
Corresponding EE PR:
appsmithorg/appsmith-ee#4191

Fixes #33486   

## Automation

/ok-to-test tags="@tag.Settings, @tag.LicenseAndBilling"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9096922670>
> Commit: 559bcd6
> Cypress dashboard: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9096922670&attempt=3&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank"> Click here!</a>
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/ProductRamps/PrivateEmbedRamp_spec.ts
</ol>
> To know the list of identified flaky tests - <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">Refer here</a>

<!-- end of auto-generated comment: Cypress test results  -->






## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 15, 2024
@github-actions github-actions bot added Query & JS Pod Issues related to the query & JS Pod QA Pod Issues under the QA Pod labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NilanshBansal NilanshBansal

Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added serialization for LicenseCE appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @NilanshBansal @appsmith-bot