Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating js error and validation error for debugger #4361

Merged
merged 10 commits into from
May 12, 2021
Merged

Separating js error and validation error for debugger #4361

merged 10 commits into from
May 12, 2021

Conversation

ApekshaBhosale
Copy link
Contributor

@ApekshaBhosale ApekshaBhosale commented May 7, 2021 •
edited by github-actions bot
Loading

Description

Show js error during evaluation and send error it to debugger

Fixes #822

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: fix/show-js-error-rewrite
Status File % Stmts % Branch % Funcs % Lines
🔴 total 48.94 (0) 28.65 (-0.05) 26.78 (0) 49.3 (-0.02)
🔴 app/client/src/components/editorComponents/CodeEditor/EvaluatedValuePopup.tsx 65.38 (0) 58.73 (-3.98) 42.31 (0) 68.06 (0)
🟢 app/client/src/components/editorComponents/CodeEditor/index.tsx 73.68 (0.14) 53.98 (0.83) 56.67 (0) 73.74 (0.14)
🔴 app/client/src/components/propertyControls/CodeEditorControl.tsx 35.48 (-1.19) 0 (0) 50 (0) 38.46 (-1.54)
🔴 app/client/src/components/propertyControls/InputTextControl.tsx 35.9 (-0.94) 0 (0) 33.33 (0) 35.14 (-0.97)
🔴 app/client/src/pages/Editor/PropertyPane/PropertyControl.tsx 19.53 (-0.8) 0 (0) 0 (0) 20.49 (-1.25)
🔴 app/client/src/reducers/uiReducers/debuggerReducer.ts 37.04 (0) 5.56 (-1.58) 16.67 (0) 40 (0)
🔴 app/client/src/sagas/ActionExecutionSagas.ts 12.34 (-0.03) 1.35 (-0.05) 7.41 (0) 14.16 (-0.04)
🔴 app/client/src/sagas/DebuggerSagas.ts 15.84 (-0.65) 3.28 (-0.23) 28.57 (0) 17.2 (-0.98)
🔴 app/client/src/sagas/EvaluationsSaga.ts 20.83 (-0.15) 1.67 (-0.25) 5 (0) 23.62 (-0.19)
🔴 app/client/src/selectors/propertyPaneSelectors.tsx 60.71 (-2.25) 46.15 (0) 100 (0) 59.26 (-2.28)
🔴 app/client/src/workers/DataTreeEvaluator.ts 88.71 (0.03) 76.96 (-1.42) 87.32 (0) 88.84 (-0.02)
🟢 app/client/src/workers/evaluationUtils.ts 89.13 (0.43) 78.43 (0.98) 90.48 (0) 88.94 (0.5)

@ApekshaBhosale ApekshaBhosale changed the title Fix/show js error rewrite Separating js error and validation error for debuuger May 7, 2021
@ApekshaBhosale ApekshaBhosale changed the title Separating js error and validation error for debuuger Separating js error and validation error for debugger May 7, 2021
mohanarpit
mohanarpit previously approved these changes May 7, 2021
View reviewed changes
@ApekshaBhosale
Copy link
Contributor Author

/ok-to-test sha=50aa8a7

@ApekshaBhosale
Copy link
Contributor Author

/ok-to-test sha=c54c587

mohanarpit
mohanarpit previously approved these changes May 11, 2021
View reviewed changes
@ApekshaBhosale ApekshaBhosale merged commit c6a8f81 into release May 12, 2021
@ApekshaBhosale ApekshaBhosale deleted the fix/show-js-error-rewrite branch May 12, 2021 06:40
ApekshaBhosale added a commit that referenced this pull request May 12, 2021
@ApekshaBhosale
Revert "Separating js error and validation error for debugger (#4361)"
c6ff255 
This reverts commit c6a8f81.
ApekshaBhosale added a commit that referenced this pull request May 13, 2021
@ApekshaBhosale
Revert "Separating js error and validation error for debugger (#4361)" (
66c7a0b 
#4447)

This reverts commit c6a8f81.
@ApekshaBhosale ApekshaBhosale restored the fix/show-js-error-rewrite branch May 13, 2021 06:30
pedro-santos-rodrigues pushed a commit that referenced this pull request Jun 20, 2024
@yatinappsmith
CI: Add attempt to workflow (#4361)
b475bb7 
Add attempt to workflow

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
    - Added a new field to capture GitHub run attempt number.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanarpit mohanarpit mohanarpit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][High][Release] When there is a binding error we should show error instead of undefined in current value
2 participants
@ApekshaBhosale @mohanarpit