fix: Tabs widget - full height when showTabs is false #6949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsartisan
previously approved these changes
Sep 1, 2021
| @@ -42,7 +42,7 @@ const TabsContainerWrapper = styled.div<{ | |||
| `; | |||
|
|
|||
| const ChildrenWrapper = styled.div` | |||
| height: calc(100% - 40px); | |||
There was a problem hiding this comment.
Do we know why we subtracted this 40px before?
There was a problem hiding this comment.
Maybe to consider for the tab height as it's 40px, not 100% sure.
|
@ashit-rath It looks that placing any other widget on the tab widget changes position due to grid change. If I place any widget at bottom of tab then it's getting cropped. |
|
@vivekverma2312 Regarding the chart widget issue you mentioned, I think that is out of the scope of this issue as this is regarding the grey bar that we see. Can you maybe create a new issue stating that? |
ashit-rath
changed the title
ashit-rath
changed the title
jsartisan
approved these changes
Sep 6, 2021
|
@ashit-rath @jsartisan kindly dont push small issue like this to QA pipeline, As stated before, The reviewer can test the Deploy preview while looking at the code and then push to the done pipeline |
albinAppsmith
added a commit
that referenced
this pull request
Sep 9, 2021
* updated organization setting ui * fixed issue of text input dom * Update lockfile with current dependencies (#7117) The yarn.lock file is currently out-of-sync with the dependencies we are using. So, running yarn install --frozen-lockfile fails with the following error: yarn install v1.22.10 [1/5] 🔍 Validating package.json... [2/5] 🔍 Resolving packages... error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. This commit gets it back in shape. * feat: on chart widget set adaptive y-axis based on data (#6310) * enhancement on chart props * updates as required * changed data for chart widget * fixed build issue * improve code * update text * Update propertyConfig.ts * changed helpText Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> * feat: make comments publicly available (#7143) * feat: Adding labels to PR based on their title (#7162) * [skip_changelog] Feature/directory structure for version control (#6757) * Insert git application metadata to application object, for git sync/version control feature there is a need to save the application in the structured format * Added changelog to index application collection with git branch and remoteurl * Rehydrate and dehydrate applications among different instances * Added serailisation purpose while exporting the application to make distinction between version control and regular import-export flow * Git file operations moved to appsmith-git module * Delete json reference from directory for deleted resource in DB * Added git authentication in application metadata * Replace String with Path to handle file path in git file structure * fix: Running the PR labeler when a PR is edited (#7168) This ensures that the labels are correct & synchronized with the latest PR details * feat: API to save git config data (#6930) * API to save git config data * Store the git config data as global/default property in user data object * Add API to fetch the config for the user * fix: add expected structure example to api pane based on the new validation structure (#6886) * Added null check in tern autocomplete (#7160) * fix: Updated Template (#7169) * Updated Template * Updated Template * Updated Template * ci: Using appsmith's fork of labeler for minor enhancement & easier config (#7177) Now we can add multiple title regexes for a PR and the labeler will automatically tag the PR with the appropriate labels. This will be useful when generated the release notes in a categorized fashion. * Updated Template * fix: fix Arangodb plugin response on update commands (#7182) * ArangoDB has two types of command - one that fetches a response and the other that updates a document. Currently, ArangoDB plugin treats all cmds like the one that returns a response, hence when update cmds are run then an empty response is returned to the client since there is nothing to fetch. This PR adds a check to fetch the response based on the type of cmd. Hence, for an update cmd the number of writes succeeded or failed would be returned as a response. * fix: safeguarding selected widgets saga (#7133) * fix: snippets UI (#7173) Changes to snippets tab color and removed play icon on snippet. * fix: resize breaks DnD (#7174) This is an important fix for a blocker in release. Force merging * Use BigDecimal to maintain precision (#7189) * feat: Show contextual search menu for debugger errors (#7078) * feat: Removed unnecessary fields from exported application (#7198) Removed unnecessary fields from exported application * fix: center alignment for profile placeholder (#7197) * fix: close notifications list on clicking a list item (#7178) * List widget UI test cases (#5535) * List Widget UI Test Cases List Widget UI Test Cases: Change the List Widget Name Add or Modify items Change the Background Color Change the Item Background Color Enable Disable Visible Enable Disable Visible - JS Adding Query/API Copy Widget Delete Widget Change the list and item background color using JS Button * Update List_spec.js * fix: handle resolved/deleted comment threads after they're fetched (#7185) * fix: text overflow gen CRUD form (#7180) Fix #7151 : Text overflows the row when the table's column name is more than 25 characters. * fix: omit props passing to DOM element (#7181) * chore: jest state update on unmount error (#7141) Add clearTimeout to avoid setState on unMount * fix: Fetch all the schemas present in the postgres DB (#7204) * Remove schema check from tables query for postgres DB in fetch structure * fix: try making create new thread transition better (#7200) * test: Select UI test cases (#6328) * Select/MultiSelect widget UI test cases * Select/MultiSelect Test Cases Dropdown-AlertModal Dropdown-FromModal Dropdown-Call-Api Dropdown-Call-Query Toggle JS - Dropdown-Call-Query Toggle JS - Dropdown-CallAnApi Validation Verify Search box for selecting drop-down options Verify Dropdown default value Dropdown Icon Visibility Explore Widget related documents Dropdown Close On Option Change Action Copy paste dropdown Dropdown-Delete Toggle JS - Dropdown-Unckeck Visible field Toggle JS - Dropdown-ckeck Visible field * Added new file button file and fixed the bugs in chart and button Added new file button file and fixed the bugs in chart and button * Fixed JS toggle for Button widget * Added go to edit page from published page * Removed the multiselect test cases from dropdown * Select ui test cases fixes * Select UI test fixes * fix: persist draft comments on clicking outside (#7156) * fix: Tabs widget - full height when showTabs is false (#6949) * Fix - Tabs widget - full height when showTabs is false * added conditional height for ChildrenWrapper based on tab visibility state * fix: stop creating private thread if someone tagged a user in their first comment (#7205) * feat: Consistent styling for widgets disabled state (#6983) * checkbox and button default styling * rate widget disabled styling * added cursor: not-allowed to disable css * fix: snippets meta and short title (#7216) * FIX #4952 : checked array before spread (#7027) * fix: Filter columns which has a column accessor (#7101) * Filter columns which has does not have a column accessor property * wrapped header text in AutotooltipComponent (#7186) Co-authored-by: rashmi rai <rashmirai@appsmith.com> * fix: Undoing delete widget does not restore the errors in the debugger (#7232) * feat: New widget - Audio Recorder widget (#6702) User can record audio / play it as feedback and then use the data in any API with the help of this new widget * feat: Updating query fom render according to new json structure (#7188) * Updated renderEachConfig function, changed keys for eval storing * Removed unused imports * feat: Changes to add js plugin (#4861) Adds server side changes for supporting JS editor * fix: property pane (#7157) * updated widget properties * updated placeholders * updated default for date * lint fix * Fixed more styles and reverted changes to input widget * adjusted default sizes of different widgets * resized image in list widget * reduced chart default data * fixed tests * PR comment fixes * fixed tests failing * fix: Fixed failing jest tests because of an error in chart widget propertyConfig object Co-authored-by: somangshu <somangshu.goswami1508@gmail.com> * feat: Generate and store ssh key to git meta data of application (#7184) - Added new API that generates a new ssh key pair and stores that inside the git meta data of an application. The key is generated in open ssh format. The private key is stored as encrypted in DB. * feat: JS Editor (#6003) * Changes to add js plugin * routes+reducer+create template * added debugger to js editor page * entity explorer changes * create js function * added copy, move and delete action * added js plugin * added existing js functions to data tree * removed actionconfig for js collection * new js function added to data tree and entity as well * parsing flow added * changes to data tree * parse and update js functions * small changes for def creator for js action * create delete modified * small changes for update * update flow change * entity properties added * removed linting errors * small changes in entity explorer * changes for update * move, copy implementation * conflict resolved * changes for dependecy map creation * Only make the variables the binding paths * Basic eval sync working * Minor fixes * removed unwanted code * entity props and autocomplete * saving in progress show * redirection fix after delete js action * removed unnecessary line * Fixing merge conflict * added sample body * removed dummy data and added plugin Type * few PR comments fixed * automplete fix * few more PR comments fix * PR commnets fix * move and copy api change * js colleciton name refactor & 'move to page' changes & search * view changes * autocomplete added for js collections * removing till async is implemented * small changes * separate js pane response view * Executing functions * js collection to js objects * entity explorer issue and resolve action on page switch * removed unused line * small color fix * js file icon added * added js action to property pane * Property pane changes for actions * property pane changes for js functions * showing syntax error for now * actions sorted in response tab * added js objects to slash and recent entitties * enabling this to be used inside of function * eval fix * feature flag changes for entity explorer and property pane * debugger changes * copy bug fix * small changes for eval * debugger bug fix * chnaged any to specific types * error in console fix * icons update * fixed test case * test case fix * non empty check for functions * evaluate test case fix * added new icons * text change * updated time for debounce for trial * after release mereg * changed icon * after merge * PR comments simple * fixed PR comments - redux form, settings remove * js object interface changes * name refactor * export default change * delete resolve actions chnage * after merge * adding execute fn as 3rd option and removed create new js function * issue 7054 fixed - app crash * execute function on response tab changes * refactor function name part 1 * refactor of js function name * try catch added refactor * test fix * not used line removed * test cases locator fixed Co-authored-by: Nidhi <nidhi.nair93@gmail.com> Co-authored-by: hetunandu <hetu@appsmith.com> * fixed issue button for normal style and remove font color setting on ApplicationCard component * revert overlay setting over app card Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com> Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com> Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com> Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com> Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com> Co-authored-by: Sumit Kumar <sumit@appsmith.com> Co-authored-by: Pranav Kanade <pranav@appsmith.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: Nidhi <nidhi@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com> Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com> Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com> Co-authored-by: ashit-rath <88306433+ashit-rath@users.noreply.github.com> Co-authored-by: Albin <albin@appsmith.com> Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com> Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com> Co-authored-by: rashmi rai <89374972+rashmi-rai@users.noreply.github.com> Co-authored-by: rashmi rai <rashmirai@appsmith.com> Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com> Co-authored-by: Ayush Pahwa <ayushpahwa96@gmail.com> Co-authored-by: somangshu <somangshu.goswami1508@gmail.com> Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com> Co-authored-by: Nidhi <nidhi.nair93@gmail.com> Co-authored-by: hetunandu <hetu@appsmith.com>
albinAppsmith
added a commit
that referenced
this pull request
Sep 9, 2021
* application card UI seperation * Homepage UI changes * Update lockfile with current dependencies (#7117) The yarn.lock file is currently out-of-sync with the dependencies we are using. So, running yarn install --frozen-lockfile fails with the following error: yarn install v1.22.10 [1/5] 🔍 Validating package.json... [2/5] 🔍 Resolving packages... error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. This commit gets it back in shape. * feat: on chart widget set adaptive y-axis based on data (#6310) * enhancement on chart props * updates as required * changed data for chart widget * fixed build issue * improve code * update text * Update propertyConfig.ts * changed helpText Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> * feat: make comments publicly available (#7143) * feat: Adding labels to PR based on their title (#7162) * [skip_changelog] Feature/directory structure for version control (#6757) * Insert git application metadata to application object, for git sync/version control feature there is a need to save the application in the structured format * Added changelog to index application collection with git branch and remoteurl * Rehydrate and dehydrate applications among different instances * Added serailisation purpose while exporting the application to make distinction between version control and regular import-export flow * Git file operations moved to appsmith-git module * Delete json reference from directory for deleted resource in DB * Added git authentication in application metadata * Replace String with Path to handle file path in git file structure * fix: Running the PR labeler when a PR is edited (#7168) This ensures that the labels are correct & synchronized with the latest PR details * feat: API to save git config data (#6930) * API to save git config data * Store the git config data as global/default property in user data object * Add API to fetch the config for the user * fix: add expected structure example to api pane based on the new validation structure (#6886) * Added null check in tern autocomplete (#7160) * fix: Updated Template (#7169) * Updated Template * Updated Template * Updated Template * ci: Using appsmith's fork of labeler for minor enhancement & easier config (#7177) Now we can add multiple title regexes for a PR and the labeler will automatically tag the PR with the appropriate labels. This will be useful when generated the release notes in a categorized fashion. * Updated Template * fix: fix Arangodb plugin response on update commands (#7182) * ArangoDB has two types of command - one that fetches a response and the other that updates a document. Currently, ArangoDB plugin treats all cmds like the one that returns a response, hence when update cmds are run then an empty response is returned to the client since there is nothing to fetch. This PR adds a check to fetch the response based on the type of cmd. Hence, for an update cmd the number of writes succeeded or failed would be returned as a response. * fix: safeguarding selected widgets saga (#7133) * fix: snippets UI (#7173) Changes to snippets tab color and removed play icon on snippet. * fix: resize breaks DnD (#7174) This is an important fix for a blocker in release. Force merging * Use BigDecimal to maintain precision (#7189) * feat: Show contextual search menu for debugger errors (#7078) * feat: Removed unnecessary fields from exported application (#7198) Removed unnecessary fields from exported application * fix: center alignment for profile placeholder (#7197) * fix: close notifications list on clicking a list item (#7178) * List widget UI test cases (#5535) * List Widget UI Test Cases List Widget UI Test Cases: Change the List Widget Name Add or Modify items Change the Background Color Change the Item Background Color Enable Disable Visible Enable Disable Visible - JS Adding Query/API Copy Widget Delete Widget Change the list and item background color using JS Button * Update List_spec.js * fix: handle resolved/deleted comment threads after they're fetched (#7185) * fix: text overflow gen CRUD form (#7180) Fix #7151 : Text overflows the row when the table's column name is more than 25 characters. * fix: omit props passing to DOM element (#7181) * chore: jest state update on unmount error (#7141) Add clearTimeout to avoid setState on unMount * fix: Fetch all the schemas present in the postgres DB (#7204) * Remove schema check from tables query for postgres DB in fetch structure * fix: try making create new thread transition better (#7200) * test: Select UI test cases (#6328) * Select/MultiSelect widget UI test cases * Select/MultiSelect Test Cases Dropdown-AlertModal Dropdown-FromModal Dropdown-Call-Api Dropdown-Call-Query Toggle JS - Dropdown-Call-Query Toggle JS - Dropdown-CallAnApi Validation Verify Search box for selecting drop-down options Verify Dropdown default value Dropdown Icon Visibility Explore Widget related documents Dropdown Close On Option Change Action Copy paste dropdown Dropdown-Delete Toggle JS - Dropdown-Unckeck Visible field Toggle JS - Dropdown-ckeck Visible field * Added new file button file and fixed the bugs in chart and button Added new file button file and fixed the bugs in chart and button * Fixed JS toggle for Button widget * Added go to edit page from published page * Removed the multiselect test cases from dropdown * Select ui test cases fixes * Select UI test fixes * fix: persist draft comments on clicking outside (#7156) * fix: Tabs widget - full height when showTabs is false (#6949) * Fix - Tabs widget - full height when showTabs is false * added conditional height for ChildrenWrapper based on tab visibility state * fix: stop creating private thread if someone tagged a user in their first comment (#7205) * feat: Consistent styling for widgets disabled state (#6983) * checkbox and button default styling * rate widget disabled styling * added cursor: not-allowed to disable css * fix: snippets meta and short title (#7216) * Homepage ui fixes * FIX #4952 : checked array before spread (#7027) * fix: Filter columns which has a column accessor (#7101) * Filter columns which has does not have a column accessor property * wrapped header text in AutotooltipComponent (#7186) Co-authored-by: rashmi rai <rashmirai@appsmith.com> * fix: Undoing delete widget does not restore the errors in the debugger (#7232) * feat: New widget - Audio Recorder widget (#6702) User can record audio / play it as feedback and then use the data in any API with the help of this new widget * feat: Updating query fom render according to new json structure (#7188) * Updated renderEachConfig function, changed keys for eval storing * Removed unused imports * feat: Changes to add js plugin (#4861) Adds server side changes for supporting JS editor * fix: property pane (#7157) * updated widget properties * updated placeholders * updated default for date * lint fix * Fixed more styles and reverted changes to input widget * adjusted default sizes of different widgets * resized image in list widget * reduced chart default data * fixed tests * PR comment fixes * fixed tests failing * fix: Fixed failing jest tests because of an error in chart widget propertyConfig object Co-authored-by: somangshu <somangshu.goswami1508@gmail.com> * feat: Generate and store ssh key to git meta data of application (#7184) - Added new API that generates a new ssh key pair and stores that inside the git meta data of an application. The key is generated in open ssh format. The private key is stored as encrypted in DB. * feat: JS Editor (#6003) * Changes to add js plugin * routes+reducer+create template * added debugger to js editor page * entity explorer changes * create js function * added copy, move and delete action * added js plugin * added existing js functions to data tree * removed actionconfig for js collection * new js function added to data tree and entity as well * parsing flow added * changes to data tree * parse and update js functions * small changes for def creator for js action * create delete modified * small changes for update * update flow change * entity properties added * removed linting errors * small changes in entity explorer * changes for update * move, copy implementation * conflict resolved * changes for dependecy map creation * Only make the variables the binding paths * Basic eval sync working * Minor fixes * removed unwanted code * entity props and autocomplete * saving in progress show * redirection fix after delete js action * removed unnecessary line * Fixing merge conflict * added sample body * removed dummy data and added plugin Type * few PR comments fixed * automplete fix * few more PR comments fix * PR commnets fix * move and copy api change * js colleciton name refactor & 'move to page' changes & search * view changes * autocomplete added for js collections * removing till async is implemented * small changes * separate js pane response view * Executing functions * js collection to js objects * entity explorer issue and resolve action on page switch * removed unused line * small color fix * js file icon added * added js action to property pane * Property pane changes for actions * property pane changes for js functions * showing syntax error for now * actions sorted in response tab * added js objects to slash and recent entitties * enabling this to be used inside of function * eval fix * feature flag changes for entity explorer and property pane * debugger changes * copy bug fix * small changes for eval * debugger bug fix * chnaged any to specific types * error in console fix * icons update * fixed test case * test case fix * non empty check for functions * evaluate test case fix * added new icons * text change * updated time for debounce for trial * after release mereg * changed icon * after merge * PR comments simple * fixed PR comments - redux form, settings remove * js object interface changes * name refactor * export default change * delete resolve actions chnage * after merge * adding execute fn as 3rd option and removed create new js function * issue 7054 fixed - app crash * execute function on response tab changes * refactor function name part 1 * refactor of js function name * try catch added refactor * test fix * not used line removed * test cases locator fixed Co-authored-by: Nidhi <nidhi.nair93@gmail.com> Co-authored-by: hetunandu <hetu@appsmith.com> * Added helper function for time text * commenting dropdown_spec (#7271) * fix: convert message to string if it is not to avoid crash (#7272) * Revert "fix: property pane (#7157)" This reverts commit 72f667b. * Homepage header design complete * Header fixes * header padding fix Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com> Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com> Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com> Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com> Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com> Co-authored-by: Sumit Kumar <sumit@appsmith.com> Co-authored-by: Pranav Kanade <pranav@appsmith.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: Nidhi <nidhi@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com> Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com> Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com> Co-authored-by: ashit-rath <88306433+ashit-rath@users.noreply.github.com> Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com> Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com> Co-authored-by: rashmi rai <89374972+rashmi-rai@users.noreply.github.com> Co-authored-by: rashmi rai <rashmirai@appsmith.com> Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com> Co-authored-by: Ayush Pahwa <ayushpahwa96@gmail.com> Co-authored-by: somangshu <somangshu.goswami1508@gmail.com> Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com> Co-authored-by: Nidhi <nidhi.nair93@gmail.com> Co-authored-by: hetunandu <hetu@appsmith.com> Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4747
Type of change
How Has This Been Tested?
Manually
Checklist:
Test coverage results 🧪
🟢 Total coverage has increased