Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use errors=remount-ro mount option with ext3 filesystems only #4802

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

cclerget
Copy link
Collaborator

Description of the Pull Request (PR):

Since 5.4.0 kernel passing errors=remount-ro with squashfs mount options returns an error, fix that by conditionally set this option for ext3 filesystems only.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

Attn: @singularity-maintainers

@cclerget cclerget added this to the 3.5.1 milestone Nov 27, 2019
@cclerget cclerget self-assigned this Nov 27, 2019
Copy link
Contributor

@jmstover jmstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a syscall.Mount in pkg/ocibundle/sif/bundle_linux.go ... Does that need modified as well?

Edit:
And in internal/pkg/runtime/engine/imgbuild/create_linux.go there's a rpcOpt.Mount that's passing errors=remount-ro ... not sure if it's relevant

@cclerget
Copy link
Collaborator Author

There's a syscall.Mount in pkg/ocibundle/sif/bundle_linux.go ... Does that need modified as well?

Edit:
And in internal/pkg/runtime/engine/imgbuild/create_linux.go there's a rpcOpt.Mount that's passing errors=remount-ro ... not sure if it's relevant

Good catch both fixed. Thanks !

@dtrudg dtrudg merged commit 65fa92a into apptainer:release-3.5 Nov 27, 2019
@jmstover
Copy link
Contributor

Does this need to merge back into master as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants