Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _FORTIFY_SOURCE=2 runtime failure and enable security hardening features #5433

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

cclerget
Copy link
Collaborator

@cclerget cclerget commented Jul 16, 2020

Description of the Pull Request (PR):

  • Move child stack in the BSS section, stack usage seems is around 80 bytes (the actual stack size is unchanged: 4096)
  • Switch buildmode=default to buildmode=pie to leverage kernel ASLR
  • Add _FORTIFY_SOURCE=2 and fstack-protector to CGO_CFLAGS

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

Attn: @singularity-maintainers

@cclerget cclerget added this to the 3.6.1 milestone Jul 16, 2020
@cclerget cclerget self-assigned this Jul 16, 2020
@dtrudg
Copy link
Contributor

dtrudg commented Jul 16, 2020

This would also fix #5346 I believe, due to enabling pie

@cclerget
Copy link
Collaborator Author

This would also fix #5346 I believe, due to enabling pie

Post updated, thanks !

@dtrudg dtrudg requested review from dtrudg and tri-adam July 16, 2020 13:31
@dtrudg dtrudg added the ci:e2e label Jul 16, 2020
Copy link
Contributor

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Going to ask @tri-adam to cast his eyes over it too.

Copy link
Contributor

@tri-adam tri-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @cclerget, LGTM.

@dtrudg dtrudg merged commit b15629c into apptainer:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants