Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sif layer mediaType for ORAS #5658

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Update Sif layer mediaType for ORAS #5658

merged 1 commit into from
Oct 27, 2020

Conversation

dtrudg
Copy link
Contributor

@dtrudg dtrudg commented Oct 26, 2020 •
edited
Loading

Description of the Pull Request (PR):

Use the format discussed in the reference on #4437 going forward. Allow
our existing 'prototype' mediaType to be handles for images already
pushed into ORAS.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

Attn: @singularity-maintainers

@dtrudg dtrudg added this to the 3.7.0 milestone Oct 26, 2020
@dtrudg dtrudg self-assigned this Oct 26, 2020
@dtrudg dtrudg marked this pull request as draft October 26, 2020 15:01
@dtrudg dtrudg added the ci:e2e label Oct 26, 2020
@dtrudg dtrudg marked this pull request as ready for review October 27, 2020 14:44
ikaneshiro
ikaneshiro approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@ikaneshiro ikaneshiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just a typo in a comment

e2e/pull/pull.go Outdated Show resolved Hide resolved
@dtrudg dtrudg mentioned this pull request Oct 27, 2020
Closed
@dtrudg
Update Sif layer mediaType for ORAS
cd66c7c 
Fixes: #4437

Use the format discussed in the reference on #4437 going forward. Allow
our existing 'prototype' mediaType to be handled for images already
pushed into ORAS. Test pulling inmages with the new and old layer
mediaTypes in e2e/pull.
@dtrudg
Copy link
Contributor Author

dtrudg commented Oct 27, 2020

Corrected for the conversation in #4437 around the .sif instead of +sif at the end of the mediaType

@dtrudg
Copy link
Contributor Author

dtrudg commented Oct 27, 2020

Okay - let's do this. Think it's pretty uncontroversial to match the opencontainers example :-)

@dtrudg dtrudg merged commit 2f22751 into apptainer:master Oct 27, 2020
@dtrudg dtrudg deleted the issue4437 branch October 27, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikaneshiro ikaneshiro ikaneshiro approved these changes

@tri-adam tri-adam Awaiting requested review from tri-adam

Assignees

@dtrudg dtrudg

Labels
ci:e2e
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

Clarify and correct OCI Artifact Type for SIF
2 participants
@dtrudg @ikaneshiro