Configuring a custom logo, drops the favicon #27
Labels
bug
Something isn't working
Comments
simu
added a commit
that referenced
this issue
Jun 9, 2022
When the OCP console is customized, the default favicon is not served, which is an intentional design decision, as documented in https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c1. However, that bugzilla provides a workaround to restore the default favicon when the console is customized, cf. https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c3. We implement this workaround in this commit if the console logo is customized, and a custom hostname is configured, as we otherwise can't configure `spec.hostname` for the additional route. Ideally, we'd like to allow users to configure a custom favicon if they're customizing the logo, but that's currently not possible. Fixes #27
4 tasks
simu
added a commit
that referenced
this issue
Jun 10, 2022
When the OCP console is customized, the default favicon is not served, which is an intentional design decision, as documented in https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c1. However, that bugzilla provides a workaround to restore the default favicon when the console is customized, cf. https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c3. We implement this workaround in this commit if the console logo is customized, and a custom hostname is configured, as we otherwise can't configure `spec.hostname` for the additional route. Ideally, we'd like to allow users to configure a custom favicon if they're customizing the logo, but that's currently not possible. Fixes #27
simu
added a commit
that referenced
this issue
Jun 10, 2022
When the OCP console is customized, the default favicon is not served, which is an intentional design decision, as documented in https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c1. However, that bugzilla provides a workaround to restore the default favicon when the console is customized, cf. https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c3. We implement this workaround in this commit if the console logo is customized, and a custom hostname is configured, as we otherwise can't configure `spec.hostname` for the additional route. Ideally, we'd like to allow users to configure a custom favicon if they're customizing the logo, but that's currently not possible. Fixes #27
simu
added a commit
that referenced
this issue
Jun 10, 2022
When the OCP console is customized, the default favicon is not served, which is an intentional design decision, as documented in https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c1. However, that bugzilla provides a workaround to restore the default favicon when the console is customized, cf. https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c3. We implement this workaround in this commit if the console logo is customized, and a custom hostname is configured, as we otherwise can't configure `spec.hostname` for the additional route. Ideally, we'd like to allow users to configure a custom favicon if they're customizing the logo, but that's currently not possible. Fixes #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to Reproduce the Problem
Actual Behavior
No favicon is displayed.
Other observations
Expected Behavior
A favicon is displayed
Implementation idea
This is a known upstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1844883. The upstream issue explains how to work around. We can implement that into this component using an existing favicon (the default shown when no logo is configured).
Optional for bonus points: allow configuring also a custom favicon.
The text was updated successfully, but these errors were encountered: