Generate favicon Route if a custom logo is configured
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
changed the title
simu
changed the title
Route if a custom logo is configured
simu
force-pushed
the
fix/custom-logo-favicon
branch
2 times, most recently
from
a995157
to
45453b8
Compare
When the OCP console is customized, the default favicon is not served, which is an intentional design decision, as documented in https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c1. However, that bugzilla provides a workaround to restore the default favicon when the console is customized, cf. https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c3. We implement this workaround in this commit if the console logo is customized, and a custom hostname is configured, as we otherwise can't configure `spec.hostname` for the additional route. Ideally, we'd like to allow users to configure a custom favicon if they're customizing the logo, but that's currently not possible. Fixes #27
simu
force-pushed
the
fix/custom-logo-favicon
branch
from
45453b8
to
4862292
Compare
bastjan
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the OCP console is customized, the default favicon is not served, which is an intentional design decision, as documented in https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c1.
However, that bugzilla provides a workaround to restore the default favicon when the console is customized, cf. https://bugzilla.redhat.com/show_bug.cgi?id=1844883#c3. We implement this workaround in this commit if the console logo is customized, and a custom hostname is configured, as we otherwise can't configure
spec.hostnamefor the additional route.Ideally, we'd like to allow users to configure a custom favicon if they're customizing the logo, but that's currently not possible.
Fixes #27
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.