Update component to support OCP4.8+ console route configuration #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component has new parameters `openshift_version` and `route` which should be used to configure a custom console hostname. On OCP4.8 the component creates a resource locker patch to add the custom console hostname to the `ingress.config.openshift.io/cluster` custom resource, as documented in [customizing the console]. The parameter `openshift_version` is used to provide users the option to still configure the OpenShift console hostname via the `console.operator.openshift.io/cluster` custom resource on OCP4.7 and older. [customizing the console]: https://docs.openshift.com/container-platform/4.8/web_console/customizing-the-web-console.html#customizing-the-console-route_customizing-web-console
Add tests for testing custom route configuration on OCP 4.7 and 4.8 (the component default).
simu
force-pushed
the
feat/support-ocp48-route-configuration
branch
from
6c46863
to
1f4c99c
Compare
This commit adjusts the implementation to fall back to the new style (OCP4.8+) console hostname configuration if the parameter `openshift_version` cannot be parsed.
Now parameter `route` supports configuring both the console and download routes. Additionally, we also give parameter `route` precedence over parameter `config.route` when compiling the component for OCP4.7 or older.
simu
force-pushed
the
feat/support-ocp48-route-configuration
branch
from
1fdeb56
to
9af8919
Compare
4 tasks
glrf
approved these changes
Oct 12, 2021
This version includes the fix for the misgenerated resource names when creating the clusterrole for resource locker patches.
simu
force-pushed
the
feat/support-ocp48-route-configuration
branch
from
8f6c5cf
to
948ef83
Compare
|
NOTE: This PR requires component-resource-locker v2.1.0 or newer |
corvus-ch
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component has new parameters
openshift_versionandroutewhich should be used to configure a custom console hostname.On OCP4.8 the component creates a resource locker patch to add the custom console hostname to the
ingress.config.openshift.io/clustercustom resource, as documented in customizing the console.The parameter
openshift_versionis used to provide users the option to still configure the OpenShift console hostname via theconsole.operator.openshift.io/clustercustom resource on OCP4.7 and older.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog