Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for deploying TLS secrets and cert-manager certificates #9

Merged
merged 5 commits into from
Oct 14, 2021
Merged

Add support for deploying TLS secrets and cert-manager certificates #9

merged 5 commits into from
Oct 14, 2021

Conversation

simu
Copy link
Member

@simu simu commented Oct 12, 2021 •
edited
Loading

Secret & certificate generation logic copied from appuio/component-openshift4-ingress#25

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Rebase after Update component to support OCP4.8+ console route configuration #8 is merged

@simu simu added the enhancement New feature or request label Oct 12, 2021
@simu simu marked this pull request as ready for review October 14, 2021 11:02
@simu simu requested a review from glrf October 14, 2021 11:02
@simu simu merged commit 50d1097 into master Oct 14, 2021
@simu simu deleted the feat/deploy-certificates branch October 14, 2021 13:45
@simu simu mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glrf glrf glrf approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simu @glrf