Update module github.com/moby/moby to v20 [SECURITY] - autoclosed #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
⚠ Artifact update problemRenovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
The artifact failure details are included below: File name: go.sum |
renovate
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v17.12.0-ce-rc1.0.20200618181300-9dc6525e6118+incompatible->v20.10.20+incompatibleGitHub Vulnerability Alerts
CVE-2022-36109
Moby is an open-source project created by Docker to enable software containerization. A bug was found in Moby (Docker Engine) where supplementary groups are not set up properly. If an attacker has direct access to a container and manipulates their supplementary group access, they may be able to use supplementary group access to bypass primary group restrictions in some cases, potentially gaining access to sensitive information or gaining the ability to execute code in that container. This bug is fixed in Moby (Docker Engine) 20.10.18. Users should update to this version when it is available. Running containers should be stopped and restarted for the permissions to be fixed. For users unable to upgrade, this problem can be worked around by not using the
"USER $USERNAME"Dockerfile instruction. Instead by callingENTRYPOINT ["su", "-", "user"]the supplementary groups will be set up properly.Thanks to Steven Murdoch for reporting this issue.
Impact
If an attacker has direct access to a container and manipulates their supplementary group access, they may be able to use supplementary group access to bypass primary group restrictions in some cases, potentially gaining access to sensitive information or gaining the ability to execute code in that container.
Patches
This bug is fixed in Moby (Docker Engine) 20.10.18. Users should update to this version when it is available.
Workarounds
This problem can be worked around by not using the
"USER $USERNAME"Dockerfile instruction. Instead by callingENTRYPOINT ["su", "-", "user"]the supplementary groups will be set up properly.References
https://www.benthamsgaze.org/2022/08/22/vulnerability-in-linux-containers-investigation-and-mitigation/
For more information
If you have any questions or comments about this advisory:
GHSA-vp35-85q5-9f25
Description
Moby is the open source Linux container runtime and set of components used to build a variety of downstream container runtimes, including Docker CE, Mirantis Container Runtime (formerly Docker EE), and Docker Desktop. Moby allows for building container images using a set of build instructions (usually named and referred to as a "Dockerfile"), and a build context, which is not unlike the CWD in which the Dockerfile instructions are executed.
Containers may be built using a variety of tools and build backends available in the Moby ecosystem; in all cases, builds may not include files outside of the build context (such as using absolute or relative-parent paths). This is enforced through both checks in the build backends, and the containerization of the build process itself.
Versions of Git where CVE-2022-39253 is present and exploited by a malicious repository, when used in combination with Moby, are subject to an unexpected inclusion of arbitrary filesystem paths in the build context, without any visible warning to the user.
This issue was originally reported by Wenxiang Qian of Tencent Blade Team, and the root-cause analysis was performed by Cory Snider of Mirantis, with assistance from Bjorn Neergaard of the same. The issue was then reported to the Git project, and Taylor Blau led the process resolving the root issue in Git.
Impact
This vulnerability originates in Git, but can be used to violate assumptions that may have security implications for users of Moby and related components. Users may rely on the fact that a build context ensures that outside files cannot be referenced or incorporated using multiple enforcement mechanisms, or expect a warning if this does not hold true. A maliciously crafted Git repository exploiting CVE-2022-39253 can violate this assumption, and potentially include sensitive files that are subsequently uploaded to a container image repository, or disclosed by code inside the resulting container image.
As this issue cannot be triggered remotely, except by users who already have full control over the daemon through the API, and it requires exploiting a vulnerability in Git by convincing a user to build a maliciously crafted repository, the impact in Moby is considered low.
Patches
Moby 20.10.20, and Mirantis Container Runtime (formerly Docker Enterprise Edition) 20.10.14 will contain mitigations for CVE-2022-39253 when a Git clone is performed by Moby components (on either the daemon or API client side). However, as these mitigations only apply to certain scenarios (build of
git+<protocol>://...URL contexts) and cannot protect against a malicious repository already on disk, users should update to a version of Git containing patches for CVE-2022-39253 on all their systems running both API clients and daemons.Specifically, patches in Moby (including patches incorporated from BuildKit) protect against the following:
docker buildwith the legacy builder (e.g.DOCKER_BUILDKITunset or set to 0) of a Git URL context. Note that depending on available API versions and the CLI version, the Git clone operation can take place on either the client or the daemon side. Both must be updated (or have Git updated) to fully protect this build method.docker buildwith the BuildKit builder (e.g.DOCKER_BUILDKIT=1) of a Git URL context.docker buildx buildwithBUILDKIT_CONTEXT_KEEP_GIT_DIR=1of a Git URL context.Patches in BuildKit incorporated into Docker Compose protect against CVE-2022-39253 during Compose-driven builds of Git URL contexts.
Patches in Moby and related projects such as BuildKit, the Docker CLI, and Docker Compose cannot fully protect against CVE-2022-39253, as it may be triggered by a malicious repository already on disk that a unpatched Git client has interacted with (specifically, commands that check out submodules such as
git clone --recursive,git submodule update, etc. may have already triggered the Git vulnerability).Workarounds
While this behavior is unexpected and undesirable, and has resulted in this security advisory, users should keep in mind that building a container entails arbitrary code execution. Users should not build a repository/build context they do not trust, as containerization cannot protect against all possible attacks.
When building with BuildKit (e.g.
docker buildx buildordocker buildwithDOCKER_BUILDKIT=1), this issue cannot be exploited unless--build-arg BUILDKIT_CONTEXT_KEEP_GIT_DIR=1was also passed, as by default BuildKit will discard the.gitdirectory of a Git URL context immediately after cloning and checking out the repository.For more information
If you have any questions or comments about this advisory:
Release Notes
moby/moby
v20.10.20+incompatibleCompare Source
v20.10.19+incompatibleCompare Source
v20.10.18+incompatibleCompare Source
v20.10.17+incompatibleCompare Source
v20.10.16+incompatibleCompare Source
v20.10.15+incompatibleCompare Source
v20.10.14+incompatibleCompare Source
v20.10.13+incompatibleCompare Source
v20.10.12+incompatibleCompare Source
v20.10.11+incompatibleCompare Source
v20.10.10+incompatibleCompare Source
v20.10.9+incompatibleCompare Source
v20.10.8+incompatibleCompare Source
v20.10.7+incompatibleCompare Source
v20.10.6+incompatibleCompare Source
v20.10.5+incompatibleCompare Source
v20.10.4+incompatibleCompare Source
v20.10.3+incompatibleCompare Source
v20.10.2+incompatibleCompare Source
v20.10.1+incompatibleCompare Source
v20.10.0+incompatibleCompare Source
v17.12.0-ce-rc4+incompatibleCompare Source
v17.12.0-ce-rc3+incompatibleCompare Source
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.