Skip to content

Commit

Permalink
Merge pull request #441 from appuniversum/chore/node-18-dev-setup
Browse files Browse the repository at this point in the history
Update the setup to node 18
  • Loading branch information
Windvis committed Oct 10, 2023
2 parents 55536c9 + b868239 commit 224f40c
Show file tree
Hide file tree
Showing 7 changed files with 35,894 additions and 27,348 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- name: Install dependencies
run: npm ci
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- name: Install Dependencies
run: npm ci
Expand All @@ -42,7 +42,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- name: Install Dependencies
run: npm install --no-shrinkwrap
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.17.x # 18.18 has as issue with thread-loader causing the process to hang: https://github.com/nodejs/node/issues/49911
cache: npm
- name: Install Dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 18.x
registry-url: "https://registry.npmjs.org"
- run: npm ci
- run: npm publish
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/storybook_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- name: Install Dependencies
run: npm ci
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ See the [Contributing](CONTRIBUTING.md) guide for details.

## Development

> We still use npm 6 during development since that's the version that's bundled with node 14.
Local development:

- Build the ember app: `npm run ember`
Expand Down
Loading

0 comments on commit 224f40c

Please sign in to comment.