Update the setup to node 18 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the dev and CI setup to node 18. node 14 (and 16) are both EOL and some tools (Prettier for example) start to depend on newer features. This only affects the dev setup. The addon doesn't really do any node logic, so it will have little influence on consumers.
This removes some dependencies that are no longer needed and forces the ember-source peerDep of storybook/ember to our own version.
- ember-focus-trap v1 has an Ember v4+ peerDependency - storybook has an Ember 3.28 peerDep - zestia/autofocus v4 doesn't support ember-source v5 yet as a peerDep
This works around an issue in node 18.18 that makes the embroider-optimized scenario hang.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the dev and CI setup to node 18. node 14 (and 16) are both EOL and some tools (Prettier for example) start to depend on newer features.
This only affects the dev setup. The addon doesn't really do any node logic, so it will have little influence on consumers.