Skip to content

Commit

Permalink
Merge pull request #405 from appuniversum/fix/aria-hidden-icons
Browse files Browse the repository at this point in the history
Use aria-hidden=true as default on icons
  • Loading branch information
Dietr committed Jul 18, 2023
2 parents 3ecd203 + 22eeffa commit d75d28e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions addon/components/au-icon.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
role="img"
class="au-c-icon au-c-icon--{{@icon}} {{this.alignment}} {{this.size}}"
aria-hidden="{{if
(or (eq @ariaHidden true) (eq @ariaHidden 'true'))
'true'
(or (eq @ariaHidden false) (eq @ariaHidden 'false'))
'false'
'true'
}}"
...attributes
>
Expand Down
2 changes: 1 addition & 1 deletion stories/5-components/Brand/AuIcon.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Component.args = {
icon: 'info-circle',
size: 'large',
alignment: '',
ariaHidden: false,
ariaHidden: true,
};

export const Icons = IconList.bind({});
Expand Down

0 comments on commit d75d28e

Please sign in to comment.