-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] - Drift Detection #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drift detection when enabled by spec.enableDriftDetection periodically runs the terraform plan. It checks for drift from the expected state and if found, changes the status and raises an event against the resource. - Updating the API types to support dirft detection
…igurations to kick off a drift
…en the condition is corev1alphav1.ConditionReady
- updated the chart deployment and values to include the drift options
This was
linked to
issues
Jun 8, 2022
Closed
gambol99
added a commit
that referenced
this pull request
Jun 8, 2022
[FEATURE] - Drift Detection Drift detection when enabled by spec.enableDriftDetection periodically runs the terraform plan. It checks for drift from the expected state and if found, changes the status and raises an event against the resource. - updated the API types to support dirft detection - added the drifting controller, the purpose of which is to tag configurations to kick off a drift - updated the filters to take into account additional labels - added some utility methods around maps and additional unit tests for yaml - added a common utility method to detected changes in the terraform output - updated the condition logging to only creates a log for success when the condition is corev1alphav1.ConditionReady - updated the configuration controller to handle drift detection - updated the chart crds - updated the chart deployment and values to include the drift options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drift detection when enabled by spec.enableDriftDetection periodicallyruns the terraform plan. It checks for drift from the expected state and if found, changes the status and raises an event against the resource. Effectively this is running another terraform plan and using the result to determine a change.
You can enable drift detection via
The controller has two new settings
Note a new status field has been added to the resource which provides an overall status to the resources
On detecting a resource has drifted the status will move to
OutOfSync
and a kubernetes event will be raised.