[FEATURE] - Namespace Protection #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently you can get into a situation where deleting a namespace before a Configurations have been removed causes the namespace to fall into a Termination failure. The issue is caused by terranetes trying to create a watcher to watch the deletion. With this PR we've added a protection layer to block namespaces from being deleted when one or more Configurations are present
gambol99
force-pushed
the
feat_block_delection
branch
from
7a9f3b1
to
11a21c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can get into a situation where deleting a namespace before a Configurations have been removed causes the namespace to fall into a Termination failure. The issue is caused by terranetes trying to create a watcher to watch the deletion. With this PR we've added a protection layer to block namespaces from being deleted when one or more Configurations are present.
The feature is disbled by default, to enable you have to configure
enableNamespaceProtection: truein the helm chart or---enable-namespace-protection=trueon command line.