-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug Report: Team Membership Create returns wrong membership #3583
Comments
From the docs, a Membership object should be returned: {
"$id": "5e5ea5c16897e",
"$createdAt": 1592981250,
"$updatedAt": 1592981250,
"userId": "5e5ea5c16897e",
"userName": "John Doe",
"userEmail": "john@appwrite.io",
"teamId": "5e5ea5c16897e",
"teamName": "VIP",
"invited": 1592981250,
"joined": 1592981250,
"confirm": false,
"roles": [
"admin"
]
} Are you saying Can you clarify what's incorrect about team? |
Indeed, userId, userName, and userEmail should be of the person being added, but right now, it returns the info of the person creating the membership. |
…name and email Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
…bership-to-return-added-name-email Fixing #3583 - create team membership to return added person name and…
Closing as should be resolved in next release. |
👟 Reproduction steps
Create a team membership, I get my membership as response instead of the newly created membership.
👍 Expected behavior
Get the newly created membership as response.
👎 Actual Behavior
I get my own membership.
I think
$email and $name
should be used instead of the
$user
.Take a look at this, as this worked fine in v0.13.4 :
https://github.com/appwrite/appwrite/blob/master/app/controllers/api/teams.php#L422
appwrite/app/controllers/api/teams.php
Line 426 in cc1ddc8
🎲 Appwrite version
Version 0.15.x
💻 Operating system
Linux
🧱 Your Environment
No response
👀 Have you spent some time to check if this issue has been raised before?
🏢 Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: