Fixing appwrite#3583 - create team membership to return added person …

…name and email
iifawzi · Jul 22, 2022 · 4ade497 · 4ade497
1 parent 9035db1
commit 4ade497
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/controllers/api/teams.php b/app/controllers/api/teams.php
@@ -427,8 +427,8 @@
         $response->dynamic(
             $membership
             ->setAttribute('teamName', $team->getAttribute('name'))
-            ->setAttribute('userName', $user->getAttribute('name'))
-            ->setAttribute('userEmail', $user->getAttribute('email')),
+            ->setAttribute('userName', $name)
+            ->setAttribute('userEmail', $email),
             Response::MODEL_MEMBERSHIP
         );
     });

diff --git a/tests/e2e/Services/Teams/TeamsBaseServer.php b/tests/e2e/Services/Teams/TeamsBaseServer.php
@@ -57,6 +57,8 @@ public function testCreateTeamMembership($data): array
         $this->assertEquals(201, $response['headers']['status-code']);
         $this->assertNotEmpty($response['body']['$id']);
         $this->assertNotEmpty($response['body']['userId']);
+        $this->assertEquals('Friend User', $response['body']['userName']);
+        $this->assertEquals($email, $response['body']['userEmail']);
         $this->assertNotEmpty($response['body']['teamId']);
         $this->assertCount(2, $response['body']['roles']);
         $this->assertIsInt($response['body']['joined']);