-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor event payload to data #1045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodumbeats
force-pushed
the
refactor-event-payload-to-data
branch
from
March 29, 2021 19:29
c6643a0
to
365d2d5
Compare
kodumbeats
added a commit
to appwrite/docs
that referenced
this pull request
Mar 29, 2021
eldadfux
requested changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor comments.
eldadfux
approved these changes
Mar 30, 2021
Waiting for tests |
🚀 |
eldadfux
added a commit
to appwrite/docs
that referenced
this pull request
Apr 10, 2021
Environment variable refactored in appwrite/appwrite#1045
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the function environment variable
APPWRITE_FUNCTION_EVENT_PAYLOAD
toAPPWRITE_FUNCTION_EVENT_DATA
. Includes breaking change, so keeping on top of0.8.x
for now.Test Plan
Existing test coverage on webhooks
Related PRs and Issue
Harmonization required after #967
Have you read the Contributing Guidelines on issues?
Yes.