Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event payload to data #1045

Merged
merged 7 commits into from
Apr 2, 2021
Merged

Conversation

kodumbeats
Copy link
Contributor

@kodumbeats kodumbeats commented Mar 29, 2021

What does this PR do?

This PR refactors the function environment variable APPWRITE_FUNCTION_EVENT_PAYLOAD to APPWRITE_FUNCTION_EVENT_DATA. Includes breaking change, so keeping on top of 0.8.x for now.

Test Plan

Existing test coverage on webhooks

Related PRs and Issue

Harmonization required after #967

Have you read the Contributing Guidelines on issues?

Yes.

@kodumbeats kodumbeats changed the base branch from dev to 0.8.x March 29, 2021 19:27
@kodumbeats kodumbeats force-pushed the refactor-event-payload-to-data branch from c6643a0 to 365d2d5 Compare March 29, 2021 19:29
Copy link
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comments.

CHANGES.md Outdated Show resolved Hide resolved
app/workers/functions.php Outdated Show resolved Hide resolved
@eldadfux
Copy link
Member

Waiting for tests

@eldadfux eldadfux merged commit f97b3e3 into 0.8.x Apr 2, 2021
@eldadfux
Copy link
Member

eldadfux commented Apr 2, 2021

🚀

eldadfux added a commit to appwrite/docs that referenced this pull request Apr 10, 2021
@eldadfux eldadfux deleted the refactor-event-payload-to-data branch April 19, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants