Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Document Response Model #1075

Merged
merged 6 commits into from
Apr 13, 2021
Merged

Feat: Document Response Model #1075

merged 6 commits into from
Apr 13, 2021

Conversation

TorstenDittmann
Copy link
Contributor

What does this PR do?

  • Adds Document Response Model by extending from Any Response
  • Exclude unused Response Models on Spec files

Client Diff: https://www.diffchecker.com/mMHRil0O
Server Diff: https://www.diffchecker.com/OT4nZXSg

Test Plan

Related PRs and Issues

appwrite/rfc#19

Have you read the Contributing Guidelines on issues?

Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM

@eldadfux
Copy link
Member

Looks very good! I think this should be a better fit in 0.8, please sync 0.8/dev for tests to pass

@eldadfux eldadfux merged commit 3a60e42 into appwrite:dev Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants