Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Add certificate collection rules for updated and certificateID #1151

Merged
merged 3 commits into from
May 17, 2021

Conversation

kodumbeats
Copy link
Contributor

What does this PR do?

When the certificates worker is passed an existing certificate document here, the following exception is thrown:

appwrite-worker-certificates    | [critical] (Job{v1-certificates} | ID: fd0afd102fa19e8d40d44a6159ea4daa | CertificatesV1 | [{"document":{"$id":"60a280d86cdd8","$permissions":{"read":[],"write":[]},"$collection":"certificates","domain":"www.carters.cloud"},"domain":"www.carters.cloud","validateTarget":false,"validateCNAME":false}]) has failed Appwrite\Database\Exception\Structure: Invalid document structure: Unknown properties are not allowed (updated, certificateId) for this collection. Make sure to follow certificates collection structure in /usr/src/code/src/Appwrite/Database/Database.php:289

This PR adds collection rules for updated and certificateId for the Certificates collection structure.

Test Plan

Verify no exception is found in

docker-compose logs appwrite-worker-certificates

on a known domain.

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes

@eldadfux eldadfux merged commit f2405dc into 0.8.x May 17, 2021
@eldadfux eldadfux deleted the fix-certificate-collection-rules-error branch June 14, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants