Feat: enable SMTP debugging when not in production #1644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorstenDittmann
approved these changes
Nov 2, 2021
eldadfux
requested changes
Dec 13, 2021
| @@ -76,6 +76,11 @@ public function run(): void | |||
| /** @var \PHPMailer\PHPMailer\PHPMailer $mail */ | |||
| $mail = $register->get('smtp'); | |||
|
|
|||
| // https://github.com/PHPMailer/PHPMailer/wiki/Troubleshooting#enabling-debug-output | |||
| if (App::getEnv('_APP_ENV') !== App::MODE_TYPE_PRODUCTION) { | |||
There was a problem hiding this comment.
This method makes more sense to me: https://github.com/utopia-php/framework/blob/master/src/App.php#L411
I would just double check we initialize the env setting in the worker scope the same way we do for the REST API.
|
@kodumbeats this is quite stale now and we've decided on a different approach for debugging. As such, can this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PHPMailer doesn't have very useful error messages by default, and in fact provides a URL to their wiki. This PR increases the debugging level of PHPMailer when not in production.
Test Plan
Check logs on failed SMTP delivery.
Unanswered questions
echothe logs by default, but I can overwrite the logging function. Willechoing logs work, or should we use the Utopia CLI lib?Related PRs and Issues
#1390
Have you read the Contributing Guidelines on issues?
Yes.