feat(locales): Add Polish(pl) translations #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christyjacob4
added
the
hacktoberfest-accepted
achromik
commented
Oct 4, 2021
| "emails.recovery.thanks": "Dziękujemy", | ||
| "emails.recovery.signature": "Zespół {{project}}", | ||
| "emails.invitation.subject": "Zaproszenie do zespołu %s w %s", | ||
| "emails.invitation.hello": "Cześć", |
There was a problem hiding this comment.
I'm not sure if the comma should be at the end, because in English translation there is no comma at the end. All punctuation is based on the English translation file.
https://github.com/appwrite/appwrite/blob/master/app/config/locale/translations/en.json#L25
In Polish translation file, I'm keeping the punctuation 1:1 with the English translation file
|
@achromik Yes, you're right . I probably made a mistake with |
christyjacob4
approved these changes
Oct 4, 2021
|
THANK YOU so much! All changes merged 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Polish (pl) translations
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
#1710
Have you read the Contributing Guidelines on issues?
(Write your answer here.)