Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh-tw.json #2134

Merged
merged 1 commit into from Oct 11, 2021
Merged

Update zh-tw.json #2134

merged 1 commit into from Oct 11, 2021

Conversation

HelloSeaNation
Copy link
Contributor

@HelloSeaNation HelloSeaNation commented Oct 8, 2021

What does this PR do?

Translate zh-tw.

Related PRs and Issues

#1727

Have you read the Contributing Guidelines on issues?

Yes I did

@christyjacob4
Copy link
Member

@HelloSeaNation Please complete the PR description with the relevant details

@HelloSeaNation
Copy link
Contributor Author

HelloSeaNation commented Oct 9, 2021

@christyjacob4, updated the PR description with issue linked, please check. I'm not sure why the tests are failing with error below as the changes I made are just translation.

1) Tests\E2E\Services\Realtime\RealtimeCustomClientTest::testConnection
Failed asserting that exception of type "WebSocket\ConnectionException" is thrown.

@christyjacob4
Copy link
Member

@HelloSeaNation There translations don't affect the test. So we can merge this

@christyjacob4 christyjacob4 merged commit 4fc9012 into appwrite:master Oct 11, 2021
@christyjacob4 christyjacob4 added the hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later label Oct 11, 2021
@christyjacob4
Copy link
Member

THANK YOU so much! All changes merged 🥳
Please reach out to me on our Discord server if you would like to claim your Appwrite swag!

@vrabe vrabe mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants