Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh-tw translation #4285

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Conversation

vrabe
Copy link
Contributor

@vrabe vrabe commented Oct 4, 2022

What does this PR do?

Update traditional Chinese (zh-tw) translation.

Test Plan

No

Related PRs and Issues

Previous translation update: #112, #688, #2134

Have you read the Contributing Guidelines on issues?

Yes

@gewenyu99
Copy link

您好,这些改动是有什么讲究的吗?我自己是小时候在大陆生活过一段时间的,但是对于台湾的常用国语翻译不是很了解。

有没有什么您引用的文献之类的,我可以对照参考来做Review,会简单一点。

谢谢!

@vrabe
Copy link
Contributor Author

vrabe commented Oct 7, 2022

國名參照的是CLDR。除了已經改名的北馬其頓(North Macedonia)外,基本上都是使用那邊的翻譯。

另外也有參考維基百科的字詞轉換,我沒細看,但大致差不多。

Copy link

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed translations against The Republic of China, Ministry of Foreign Affairs website. I want to make sure we avoid mistakes here and follow official naming guidelines.
https://www.mofa.gov.tw/CountryAreaInfo.aspx?casn=5&n=5&sms=33

app/config/locale/translations/zh-tw.json Show resolved Hide resolved
app/config/locale/translations/zh-tw.json Show resolved Hide resolved
"countries.se": "瑞典",
"countries.sz": "斯威士蘭",
"countries.sc": "塞舌爾",
"countries.sz": "史瓦濟蘭",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the country has renamed to Eswatini. But the original text is Swaziland. So I keep using 史瓦濟蘭. I can also use 史瓦帝尼 as you recommended.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just update it at this point :D

I think both names would work, but for the sake of being with the times, let's use the new name,

@vrabe
Copy link
Contributor Author

vrabe commented Oct 15, 2022

@gewenyu99 Thanks for reviewing! You must have checked a lot pages to review my change.

Copy link

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now :)

@gewenyu99 gewenyu99 added the hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later label Oct 18, 2022
@christyjacob4 christyjacob4 merged commit adb2168 into appwrite:master Dec 19, 2022
@christyjacob4
Copy link
Member

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants