-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update zh-tw translation #4285
update zh-tw translation #4285
Conversation
您好,这些改动是有什么讲究的吗?我自己是小时候在大陆生活过一段时间的,但是对于台湾的常用国语翻译不是很了解。 有没有什么您引用的文献之类的,我可以对照参考来做Review,会简单一点。 谢谢! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed translations against The Republic of China, Ministry of Foreign Affairs website. I want to make sure we avoid mistakes here and follow official naming guidelines.
https://www.mofa.gov.tw/CountryAreaInfo.aspx?casn=5&n=5&sms=33
"countries.se": "瑞典", | ||
"countries.sz": "斯威士蘭", | ||
"countries.sc": "塞舌爾", | ||
"countries.sz": "史瓦濟蘭", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, 史瓦帝尼
According to: https://www.mofa.gov.tw/CountryInfo.aspx?CASN=0&n=487&sms=33&s=90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the country has renamed to Eswatini. But the original text is Swaziland. So I keep using 史瓦濟蘭
. I can also use 史瓦帝尼
as you recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just update it at this point :D
I think both names would work, but for the sake of being with the times, let's use the new name,
@gewenyu99 Thanks for reviewing! You must have checked a lot pages to review my change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now :)
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
What does this PR do?
Update traditional Chinese (zh-tw) translation.
Test Plan
No
Related PRs and Issues
Previous translation update: #112, #688, #2134
Have you read the Contributing Guidelines on issues?
Yes