Feat db pools eldad #4330
Merged
Feat db pools eldad #4330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat-db-pools-eldad
…at-db-pools-eldad
…at-db-pools-eldad
| } catch (\Throwable $th) { | ||
| Console::error('Queue............disconnected 👎'); | ||
| $configs = [ | ||
| 'Console.DB' => Config::getParam('pools-console'), |
There was a problem hiding this comment.
any reason to use the dot in the key names? We haven't used this convention before
There was a problem hiding this comment.
I felt a space would be weird here because of the format, and camelCase would indicate a code concept while this should be a human readable format 🤔
There was a problem hiding this comment.
being an array key I think its valid to use console-db and projects-db or use the same key as the config
pools-console and pools-projects
christyjacob4
requested changes
Oct 19, 2022
Closed
christyjacob4
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updated for the database pools PR.
App::getEnv()App::isDevelopment()Pools::getDatabase()to use generic DSN connections_APP_DB__APP_DB_CONSOLEROOT_PASSto be_APP_DB_CONSOLE_APP_DB_CONSOLEand_APP_DB_PROJECTfrom docsOpen Questions:
Test Plan
Use existing tests
Related PRs and Issues
#3423
Have you read the Contributing Guidelines on issues?
Yes