Add snappy compression #4336
Closed
Add snappy compression #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precious-void
changed the title
|
@shtelzerartem , thanks for the PR! 🤯 Please give us some time to review it. |
stnguyen90
requested changes
Oct 28, 2022
stnguyen90
added
hacktoberfest-accepted
…at-4002-add-snappy-comporession
Comment on lines
+80
to
+83
| }, | ||
| { | ||
| "url": "https://github.com/shtelzerartem/storage.git", | ||
| "type": "git" |
Comment on lines
+1
to
+11
| <?php | ||
| $home = $this->getParam('home', ''); | ||
| $fileLimit = $this->getParam('fileLimit', 0); | ||
| $fileLimitHuman = $this->getParam('fileLimitHuman', 0); | ||
| $bucketPermissions = $this->getParam('bucketPermissions', null); | ||
| $fileCreatePermissions = $this->getParam('fileCreatePermissions', null); | ||
| $fileUpdatePermissions = $this->getParam('fileUpdatePermissions', null); | ||
| ?> | ||
|
|
||
| <div | ||
| data-service="storage.getBucket" |
There was a problem hiding this comment.
We need to remove this file. We no longer use it. You need to add the compression option here
https://github.com/appwrite/console/blob/72b3f26edb802517b8d1c9d02900dbb99da58d38/src/routes/console/project-%5Bproject%5D/storage/bucket-%5Bbucket%5D/settings/+page.svelte#L49
| @@ -65,7 +66,7 @@ | |||
| ->param('enabled', true, new Boolean(true), 'Is bucket enabled?', true) | |||
| ->param('maximumFileSize', (int) App::getEnv('_APP_STORAGE_LIMIT', 0), new Range(1, (int) App::getEnv('_APP_STORAGE_LIMIT', 0)), 'Maximum file size allowed in bytes. Maximum allowed value is ' . Storage::human(App::getEnv('_APP_STORAGE_LIMIT', 0), 0) . '. For self-hosted setups you can change the max limit by changing the `_APP_STORAGE_LIMIT` environment variable. [Learn more about storage environment variables](docs/environment-variables#storage)', true) | |||
| ->param('allowedFileExtensions', [], new ArrayList(new Text(64), APP_LIMIT_ARRAY_PARAMS_SIZE), 'Allowed file extensions. Maximum of ' . APP_LIMIT_ARRAY_PARAMS_SIZE . ' extensions are allowed, each 64 characters long.', true) | |||
| ->param('compression', COMPRESSION_TYPE_NONE, new WhiteList([COMPRESSION_TYPE_NONE, COMPRESSION_TYPE_GZIP, COMPRESSION_TYPE_ZSTD]), 'Compression algorithm choosen for compression. Can be one of ' . COMPRESSION_TYPE_NONE . ', [' . COMPRESSION_TYPE_GZIP . '](https://en.wikipedia.org/wiki/Gzip), or [' . COMPRESSION_TYPE_ZSTD . '](https://en.wikipedia.org/wiki/Zstd), For file size above ' . Storage::human(APP_STORAGE_READ_BUFFER, 0) . ' compression is skipped even if it\'s enabled', true) | |||
| ->param('compression', 'none', new WhiteList([COMPRESSION_TYPE_NONE, COMPRESSION_TYPE_GZIP, COMPRESSION_TYPE_ZSTD, COMPRESSION_TYPE_SNAPPY]), 'Compression algorithm choosen for compression. Can be one of ' . COMPRESSION_TYPE_NONE . ', [' . COMPRESSION_TYPE_GZIP . '](https://en.wikipedia.org/wiki/Gzip), or [' . COMPRESSION_TYPE_ZSTD . '](https://en.wikipedia.org/wiki/Zstd), or [' . COMPRESSION_TYPE_SNAPPY . '](https://en.wikipedia.org/wiki/Snappy_(compression)), For file size above ' . Storage::human(APP_STORAGE_READ_BUFFER, 0) . ' compression is skipped even if it\'s enabled', true) | |||
There was a problem hiding this comment.
Please replace the string literals with the constants in all occurances in this file
christyjacob4
requested changes
Jan 27, 2023
|
@shtelzerartem thanks a lot for your contributions during Hacktoberfest 2022! Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. I'm closing this PR as there has not been any activity on this for quite a while. If you'd like to continue working on it , feel free to create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Snappy compression adapter
Test Plan
Added 2 tests for Snappy compression similarly to ZSTD, both passed tests
testCreateBucketFileSnappyCompressiontestFilePreviewSnappyCompressionRelated PRs and Issues
Resolves #4002
Relates to my second PR #4002-utopia-php
Have you read the Contributing Guidelines on issues?
Yep :)