Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore update sdks #6099

Merged
merged 10 commits into from
Sep 7, 2023
Merged

Chore update sdks #6099

merged 10 commits into from
Sep 7, 2023

Conversation

christyjacob4
Copy link
Member

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Dockerfile Outdated
@@ -199,6 +199,10 @@ RUN chmod +x /usr/local/bin/hamster && \
# Letsencrypt Permissions
RUN mkdir -p /etc/letsencrypt/live/ && chmod -Rf 755 /etc/letsencrypt/live/

RUN apk add git openssh-client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed 👍

@eldadfux eldadfux added the waiting for release Fixed or implemented and waiting for a new version to be released label Sep 2, 2023
Dockerfile Outdated
Comment on lines 203 to 204
RUN git config --global user.email "christyjacob4@gmail.com"
RUN git config --global user.name "Christy Jacob"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

composer.json Outdated
@@ -86,7 +86,7 @@
}
],
"require-dev": {
"appwrite/sdk-generator": "0.34.*",
"appwrite/sdk-generator": "dev-master",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's release version if possible

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

released and udpated

@@ -84,6 +84,7 @@ services:
- ./public:/usr/src/code/public
- ./src:/usr/src/code/src
- ./dev:/usr/src/code/dev
- /Users/christyjacob/.ssh:/root/.ssh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@christyjacob4 christyjacob4 changed the base branch from master to 1.4.x September 7, 2023 21:38
docs/sdks/dart/CHANGELOG.md Outdated Show resolved Hide resolved
@christyjacob4 christyjacob4 merged commit 3c9f853 into 1.4.x Sep 7, 2023
2 of 3 checks passed
@abnegate abnegate deleted the chore-update-sdks branch October 25, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for release Fixed or implemented and waiting for a new version to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants