-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore update sdks #6099
Chore update sdks #6099
Conversation
Dockerfile
Outdated
@@ -199,6 +199,10 @@ RUN chmod +x /usr/local/bin/hamster && \ | |||
# Letsencrypt Permissions | |||
RUN mkdir -p /etc/letsencrypt/live/ && chmod -Rf 755 /etc/letsencrypt/live/ | |||
|
|||
RUN apk add git openssh-client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed 👍
Dockerfile
Outdated
RUN git config --global user.email "christyjacob4@gmail.com" | ||
RUN git config --global user.name "Christy Jacob" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
composer.json
Outdated
@@ -86,7 +86,7 @@ | |||
} | |||
], | |||
"require-dev": { | |||
"appwrite/sdk-generator": "0.34.*", | |||
"appwrite/sdk-generator": "dev-master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's release version if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
released and udpated
docker-compose.yml
Outdated
@@ -84,6 +84,7 @@ services: | |||
- ./public:/usr/src/code/public | |||
- ./src:/usr/src/code/src | |||
- ./dev:/usr/src/code/dev | |||
- /Users/christyjacob/.ssh:/root/.ssh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist