1.4.x #6135
Merged
1.4.x #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a previous installation is found during installation/upgrade, the user is prompted to confirm whether they want to overwrite it. We originally only accepted 'Y', but this PR changes it to accept 'y' as well to reduce friction.
…firm Make install confirmation case insensitive
The method has been removed since it's no longer necessary.
Because of the `getAttributes()` call, `$fileSecurity` was always true which lead to invalid permission check. This resulted in files being deleted when a user had delete permissions on the file even though they didn't on the bucket.
Remove route setIsActive() call
Update migration script to not remove schedule from functions
Fix fileSecurity check
Fix events not triggering functions and path not a string bugs
This is important for backwards compatibility since it wasn't possible to update a function runtime in previous versions and it was never included in the request.
- Create additional attributes for the deployments collection. - Set the commands attribute for the functions and deployments based on runtime.
Set new resourceType attribute to function since all variables were function variables.
Create phone session doesn't have anything to do with email. The key name should be email just for clarity (even though, technically, it doesn't matter).
…-key Fix create phone session abuse key
Default to function commands only if commands weren't supplied.
…ibility Fix CLI backwards compatibility
As of 1.4.0, the hostname of the executor should be executor rather than appwrite-executor. The problem is our install command always uses the existing installation's variable values as the default for the upgrade. This means the _APP_EXECUTOR_HOST will retain it's old value. This PR Adds an overwrite key to variables.php to allow overwriting the variable value regardless of whatever was in the previous installation.
Skip the cache collection because: 1. There may be * in the $id of the document which causes problems when paginating with a cursor. 1. Nothing was done to the cache collection so we don't need to process it.
Override forEachDocument() to skip the cache collection
When an older SDK executes a function without passing any data, the data param is unset/null so we need to make sure to handle that case.
Fix Not Found error when deploying function from git
Add required params for scheduled functions
Functions created by schedule or event should have the respective trigger.
Co-authored-by: Steven Nguyen <1477010+stnguyen90@users.noreply.github.com>
…nto fix-migration-issues
fix: migration issues
The accounts tests seem to be failing on the CI but I've made sure to check they pass locally. 
|
Fix function trigger
Fix: Function redeploys
Fix guests missing global scope
stnguyen90
approved these changes
Sep 7, 2023
abnegate
reviewed
Sep 7, 2023
| @@ -59,13 +60,13 @@ | |||
| 'migrations.write', | |||
| 'vcs.read', | |||
| 'vcs.write', | |||
| 'assistant.read', | |||
There was a problem hiding this comment.
Does removing this mean console can't access the assistant scope?
There was a problem hiding this comment.
How? The route is only available for admin auth but admin doesn't have the scope required 🤔
| - _APP_DB_PASS | ||
|
|
||
| appwrite-assistant: | ||
| image: appwrite/assistant:0.2.0 |
There was a problem hiding this comment.
I think this should be 0.2.1
There was a problem hiding this comment.
0.2.1 added dotenv which should only be used for dev so we're okay without it.
There was a problem hiding this comment.
Isn't it required to read the API key from the env?
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preparations for Appwrite 1.4.2
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist