Fix fileSecurity check #6102
Merged
Fix fileSecurity check #6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the `getAttributes()` call, `$fileSecurity` was always true which lead to invalid permission check. This resulted in files being deleted when a user had delete permissions on the file even though they didn't on the bucket.
2 tasks
stnguyen90
requested review from
abnegate,
TorstenDittmann and
christyjacob4
abnegate
approved these changes
Sep 1, 2023
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Because of the
getAttributes()call,$fileSecuritywas always true which lead to invalid permission check. This resulted in files being deleted when a user had delete permissions on the file even though they didn't on the bucket.Closes #6042
Test Plan
Related PRs and Issues
Checklist