Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #59

Conversation

TristonWasik
Copy link

@TristonWasik TristonWasik commented Jun 19, 2023

fix type export for latest node versions

What does this PR do?

This PR is to fix the type export issue with the latest versions of node. For example, this error being thrown in a new Vite react project:

image

Test Plan

This is a package.json change, testing includes using the SDK in a project with a newer node version.

Related PRs and Issues

An issue on the parent repo

Have you read the Contributing Guidelines on issues?

Yes

fix type export for latest node versions
@joeyouss
Copy link

Hey @TristonWasik , Please kindly note that the repository in question is marked as [READ-ONLY], indicating that creating pull requests directly on this repository is not possible. It would be highly recommended to submit a pull request to the following repository instead: https://github.com/appwrite/sdk-generator. This particular repository serves as the starting point for the project and is where proposed changes should be made.

Before proceeding with the pull request, I am tagging @lohanidamodar and @TorstenDittmann here for review regarding if this PR is indeed the solution that we might need.

@stnguyen90
Copy link
Contributor

Closing as this was already done in the sdk generator and will be in the next release.

appwrite/sdk-generator#653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants