Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing exports for web SDK #653

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

For projects with moduleResolution set to bundler in tsconfig.json, the types must be exported in the package.json file.

Closes: appwrite/sdk-for-web#54

Test Plan

Manually added in a new project and I no longer see the error:

image

I also added it to another TS project of mine that has moduleResolution set to node and that still worked as expected:

image

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

For projects with moduleResolution set to bundler in tsconfig.json, the
types must be exported in the package.json file.
@stnguyen90 stnguyen90 requested review from Meldiron and TorstenDittmann and removed request for Meldiron May 7, 2023 15:52
@lohanidamodar lohanidamodar merged commit 3dd97aa into master May 10, 2023
3 checks passed
@lohanidamodar lohanidamodar deleted the fix-web-types-export branch May 10, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Not able to detect Appwrite Web SDK Types
3 participants