Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Deno anyOf types #441

Merged
merged 4 commits into from
May 12, 2022
Merged

Fix: Deno anyOf types #441

merged 4 commits into from
May 12, 2022

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented May 6, 2022

Issue: appwrite/sdk-for-deno#7

Impementation generates:

    export type AttributeList = {
        sum: number;
        attributes: AttributeBoolean[] | AttributeInteger[] | AttributeFloat[] | AttributeEmail[] | AttributeEnum[] | AttributeUrl[] | AttributeIp[] | AttributeString[];
    }

@TorstenDittmann
Copy link
Contributor

Issue: appwrite/sdk-for-deno#7

Impementation generates:

    export type AttributeList = {
        sum: number;
        attributes: AttributeBoolean[] | AttributeInteger[] | AttributeFloat[] | AttributeEmail[] | AttributeEnum[] | AttributeUrl[] | AttributeIp[] | AttributeString[];
    }

Shouldnt it be?

export type AttributeList = {
    sum: number;
    attributes: (AttributeBoolean | AttributeInteger | AttributeFloat | AttributeEmail | AttributeEnum | AttributeUrl | AttributeIp | AttributeString)[];
}

@TorstenDittmann TorstenDittmann merged commit 7b03d75 into master May 12, 2022
@TorstenDittmann TorstenDittmann deleted the fix-deno-anyOf-type branch May 12, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants