Feat create resources #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # templates/cli/base/params.twig
…-resources # Conflicts: # templates/cli/lib/commands/init.js.twig # templates/cli/lib/questions.js.twig
# Conflicts: # templates/cli/lib/questions.js.twig
Feat pull function
Meldiron
reviewed
May 24, 2024
Meldiron
reviewed
May 24, 2024
Meldiron
reviewed
May 24, 2024
Meldiron
reviewed
May 24, 2024
Meldiron
reviewed
May 24, 2024
Meldiron
reviewed
May 24, 2024
Meldiron
reviewed
May 24, 2024
Meldiron
reviewed
May 24, 2024
# Conflicts: # templates/cli/index.js.twig # templates/cli/lib/commands/generic.js.twig
Meldiron
approved these changes
May 27, 2024
chore(cli): Allowing the use of `deploy` like `push`
refactor(cli): Changing commands from singular to plural when applicable
feat(cli): Creating function from all available templates
# Conflicts: # templates/cli/lib/commands/push.js.twig
Comment on lines
+261
to
+264
| await projectsUpdate({ | ||
| projectId: localConfig.getProject().projectId, | ||
| name: localConfig.getProject().projectName, | ||
| parseOutput: false |
There was a problem hiding this comment.
This should also push the project settings right?
There was a problem hiding this comment.
Yes. But pushing is done manually per service and auth
There was a problem hiding this comment.
The changes them self for pushing are in the other PR
|
|
||
| localConfig.setProject(response['$id'], response.name); | ||
| } else { | ||
| localConfig.setProject(answers.project.id, answers.project.name); |
There was a problem hiding this comment.
shouldn't we also get the project settings and set them too?
christyjacob4
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Interactive resources adding.
Already exists
Added
Test Plan
Tested against Appwrite version
1.5.5