feat(cli): Adding console for get & list methods #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
reviewed
May 22, 2024
Meldiron
reviewed
May 22, 2024
Meldiron
reviewed
May 22, 2024
Meldiron
reviewed
May 22, 2024
…accounts-and-instances
Feat general improvements
Feat function init improvments
Feat arg project init
…nces' into feat-multiple-accounts-and-instances # Conflicts: # templates/cli/lib/commands/push.js.twig # templates/cli/lib/config.js.twig
| @@ -94,6 +95,10 @@ const {{ service.name | caseLower }}{{ method.name | caseUcfirst }} = async ({ | |||
| {% if method.type == 'location' %} | |||
| .requiredOption(`--destination <path>`, `output file path.`) | |||
| {% endif %} | |||
| {% if methodHaveConsolePreview(method.name,service.name) %} | |||
| .option(`--console`, `Get the resource console url`) | |||
| .option(`--open`, `Use with '--console' to open the using default browser`) | |||
There was a problem hiding this comment.
shouldn't this be removed?
There was a problem hiding this comment.
Yes, when we will merge the one after
…ances Feat multiple accounts and instances
christyjacob4
temporarily deployed
to
cli-testing
GitHub Actions
Inactive
src/SDK/Language/CLI.php
Outdated
| { | ||
| return [ | ||
| /** Return true if the entered service->method is enabled for a console preview link */ | ||
| new TwigFunction('methodHaveConsolePreview', fn($method, $service) => preg_match('/^([Gg]et|[Ll]ist)/', $method) |
There was a problem hiding this comment.
Suggested change
| new TwigFunction('methodHaveConsolePreview', fn($method, $service) => preg_match('/^([Gg]et|[Ll]ist)/', $method) | |
| new TwigFunction('hasConsolePreview', fn($method, $service) => preg_match('/^([Gg]et|[Ll]ist)/', $method) |
templates/cli/base/requests/api.twig
Outdated
| @@ -17,8 +17,19 @@ | |||
| fs.writeFileSync(destination, response); | |||
| {%~ endif %} | |||
| if (parseOutput) { | |||
| {%~ if methodHaveConsolePreview(method.name,service.name) %} | |||
There was a problem hiding this comment.
Suggested change
| {%~ if methodHaveConsolePreview(method.name,service.name) %} | |
| {%~ if hasConsolePreview(method.name,service.name) %} |
Comment on lines
+184
to
+185
| globalConfig.setCurrentSession(accountId); | ||
| await deleteSession(accountId); |
There was a problem hiding this comment.
we are setting the current session to an accountID and deleting that specific one? Which means all new requests will throw 401 ?
There was a problem hiding this comment.
We're setting the current session to the last account in line using the leftSession variable right after.
christyjacob4
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added
--consoleflag to open resources at project console.Test Plan