Feat: CLI Local development #862
Conversation
Meldiron
changed the base branch from
feat-cli-g2
to
feat-multiple-accounts-and-instances
templates/cli/lib/questions.js.twig
Outdated
| type: "input", | ||
| name: "port", | ||
| message: 'Which port would you like function to listen on?', | ||
| default: async () => { | ||
| let port = 3000; |
There was a problem hiding this comment.
we should only show this prompt when the port 3000 is not available right?
you can use the when condition of inquirer to check this
There was a problem hiding this comment.
Well we could automatically also pick 3001 because its available. Should we not ask this question at all, and just tell them to use --port if they want to change it?
| .alias("functions") | ||
| .description("Run functions in the current directory.") | ||
| .option(`--functionId <functionId>`, `Function ID`) | ||
| .option(`--port <port>`, `Local port`) |
There was a problem hiding this comment.
lets fix a default port so user doesnt need to enter it
There was a problem hiding this comment.
It's optional param. If not provided ,question is asked (with default 3000 as placeholder)
| if(!port) { | ||
| let portFound = fale; | ||
| port = 3000; | ||
| while(port < 3100) { |
There was a problem hiding this comment.
while very rare, why limit the search to 100 ports? Why not set it to something higher like 6000 ?
There was a problem hiding this comment.
No idea how long that might take. And as you said, very rare. I wouldn' worry too much until we get some complains.
What does this PR do?
Implements local development in
appwrite run function.Test Plan
Related PRs and Issues
x
Have you read the Contributing Guidelines on issues?
Yes