Remove force unwrapping of incoming url parameters #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unnecessary crashes due to unrelated incoming URLs by: - guard against existence of URL components. - guard against query parameters - validate required cookies *bonus: discard result from user defaults synchronization.
This was referenced Jun 21, 2024
abnegate
reviewed
Jul 1, 2024
abnegate
reviewed
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid unnecessary crashes due to unrelated incoming URLs by:
Test Plan
Didn't see any unit test files, otherwise i'd add code coverage for them. Happy to do it if there is a testing scheme!
.registerOAuthHandler()to root view.Related PRs and Issues
Discord
https://discord.com/channels/564160730845151244/1252726652044050572
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
Most of it. Followed PR naming, and added a issue on github.