Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli bugs #931

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Fix cli bugs #931

merged 3 commits into from
Aug 7, 2024

Conversation

byawitz
Copy link
Member

@byawitz byawitz commented Aug 6, 2024

What does this PR do?

  • Fix typo
  • Better array checking in resource compering
  • Checking collection basic definition

Test Plan

image

const { Spinner, SPINNER_ARC, SPINNER_DOTS } = require('../spinner');
const { paginate } = require('../paginate');
const { questionsPushBuckets, questionsPushTeams, questionsPushFunctions, questionsGetEntrypoint, questionsPushCollections, questionPushChanges, questionPushChangesConfirmation, questionsPushMessagingTopics, questionsPushResources } = require("../questions");
const { questionsPushBuckets, questionsPushTeams, questionsPushFunctions, questionsGetEntrypoint, questionsPushCollections, questionPushChanges, questionPushChangesFix, questionsPushMessagingTopics, questionsPushResources } = require("../questions");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this variable name changed ? questionPushChangesConfirmation this was actually a better name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't exists, I'll rename it

@christyjacob4 christyjacob4 merged commit 0f54756 into master Aug 7, 2024
34 checks passed
@christyjacob4 christyjacob4 deleted the fix-cli-bugs branch August 7, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants