Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lowercase f in formatting function names #17

Closed
chr4 opened this issue Mar 16, 2019 · 1 comment
Closed

Use lowercase f in formatting function names #17

chr4 opened this issue Mar 16, 2019 · 1 comment

Comments

@chr4
Copy link

chr4 commented Mar 16, 2019

Your project looks really nice!

When reading the examples, I propose to streamline function names to correspond to the naming scheme of fmt, log and testing: fmt.Printf(), log.Printf(), t.Errorf() are all using lowercase f, whereas your package uses WarningF() DebugF() with capital Fs.

Proposal: Use lowercase f in your package as well, e.g. Warningf()

@apsdehal
Copy link
Owner

We have them already. See https://github.com/apsdehal/go-logger/blob/master/logger.go#L356 and related functions. Closing for now as "already exists".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants